r104256 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104255‎ | r104256 | r104257 >
Date:22:00, 25 November 2011
Author:maxsem
Status:ok
Tags:
Comment:
Follow-up r94762: fixed static/member function mismatch
Modified paths:
  • /trunk/extensions/wikihiero/wikihiero.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/wikihiero/wikihiero.body.php
@@ -224,7 +224,7 @@
225225 }
226226
227227 } elseif ( strchr( $code[0], '<' ) ) { // start cartouche
228 - $contentHtml .= '<td>' . self::renderGlyph( $code[0] ) . '</td>';
 228+ $contentHtml .= '<td>' . $this->renderGlyph( $code[0] ) . '</td>';
229229 $is_cartouche = true;
230230 $contentHtml .= '<td>' . self::TABLE_START . "<tr><td class='mw-hiero-box' style='height: "
231231 . intval( self::CARTOUCHE_WIDTH * $this->scale / 100 ) . "px;'></td></tr><tr><td>" . self::TABLE_START . "<tr>";
@@ -234,12 +234,12 @@
235235 . intval( self::CARTOUCHE_WIDTH * $this->scale / 100 )
236236 . "px;'></td></tr>" . '</table></td>';
237237 $is_cartouche = false;
238 - $contentHtml .= '<td>' . self::renderGlyph( $code[0] ) . '</td>';
 238+ $contentHtml .= '<td>' . $this->renderGlyph( $code[0] ) . '</td>';
239239
240240 } elseif ( $code[0] != "" ) { // assume it's a glyph or '..' or '.'
241241 $option = "height: " . $this->resizeGlyph( $code[0], $is_cartouche ) . "px;";
242242
243 - $contentHtml .= '<td>' . self::renderGlyph( $code[0], $option ) . '</td>';
 243+ $contentHtml .= '<td>' . $this->renderGlyph( $code[0], $option ) . '</td>';
244244 }
245245
246246 // block contains more than 1 glyph
@@ -259,7 +259,7 @@
260260 if ( in_array( $temp, self::$prefabs ) ) {
261261 $option = "height: " . $this->resizeGlyph( $temp, $is_cartouche ) . "px;";
262262
263 - $contentHtml .= '<td>' . self::renderGlyph( $temp, $option ) . '</td>';
 263+ $contentHtml .= '<td>' . $this->renderGlyph( $temp, $option ) . '</td>';
264264
265265 // block must be manually computed
266266 } else {
@@ -311,7 +311,7 @@
312312 } else {
313313 // resize the glyph according to the block total height
314314 $option = "height: " . $this->resizeGlyph( $t, $is_cartouche, $total ) . "px;";
315 - $temp .= self::renderGlyph( $t, $option );
 315+ $temp .= $this->renderGlyph( $t, $option );
316316 }
317317 } // end foreach
318318

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94762Started rewriting WikiHiero. So far, only parser tag works while the maint fu...maxsem14:16, 17 August 2011

Status & tagging log