r104184 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104183‎ | r104184 | r104185 >
Date:16:40, 24 November 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_17 MFT r94171
Modified paths:
  • /branches/REL1_17/phase3 (modified) (history)
  • /branches/REL1_17/phase3/includes (modified) (history)
  • /branches/REL1_17/phase3/includes/templates/NoLocalSettings.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/templates/NoLocalSettings.php
@@ -9,11 +9,18 @@
1010 if ( !isset( $wgVersion ) ) {
1111 $wgVersion = 'VERSION';
1212 }
13 -$script = $_SERVER['SCRIPT_NAME'];
14 -$path = pathinfo( $script, PATHINFO_DIRNAME ) . '/';
15 -$path = str_replace( '//', '/', $path );
16 -$ext = pathinfo( $script, PATHINFO_EXTENSION );
1713
 14+$matches = array();
 15+$ext = 'php';
 16+$path = '/';
 17+foreach( array_filter( explode( '/', $_SERVER['PHP_SELF'] ) ) as $part ) {
 18+ if( !preg_match( '/\.(php5?)$/', $part, $matches ) ) {
 19+ $path .= "$part/";
 20+ } else {
 21+ $ext = $matches[1] == 'php5' ? 'php5' : 'php';
 22+ }
 23+}
 24+
1825 # Check to see if the installer is running
1926 if ( !function_exists( 'session_name' ) ) {
2027 $installerStarted = false;
Property changes on: branches/REL1_17/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
2128 Merged /trunk/phase3/includes:r94171
Property changes on: branches/REL1_17/phase3
___________________________________________________________________
Modified: svn:mergeinfo
2229 Merged /trunk/phase3:r94171

Follow-up revisions

RevisionCommit summaryAuthorDate
r104185RELEASE-NOTES for r104184/r94171reedy16:41, 24 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94171(bug 30219) NoLocalSettings.php broken on Windows servers. Per Tim on r70711,...demon17:28, 10 August 2011

Status & tagging log