r104169 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104168‎ | r104169 | r104170 >
Date:14:58, 24 November 2011
Author:erik
Status:ok
Tags:
Comment:
follow-up to r104167: spelling fixes ("to many"->"too many")
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizardHooks.php (modified) (history)
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizardUpload.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizardHooks.php
@@ -399,9 +399,9 @@
400400 'wm-license-cc-by-sa-3.0-no-text',
401401 'wm-license-cc-by-sa-3.0-pl-text',
402402 'wm-license-cc-by-sa-3.0-ro-text',
403 - 'mwe-upwiz-to-many-files-ok',
404 - 'mwe-upwiz-to-many-files-text',
405 - 'mwe-upwiz-to-many-files',
 403+ 'mwe-upwiz-too-many-files-ok',
 404+ 'mwe-upwiz-too-many-files-text',
 405+ 'mwe-upwiz-too-many-files',
406406 ),
407407 'group' => 'ext.uploadWizard'
408408 ),
Index: trunk/extensions/UploadWizard/UploadWizard.i18n.php
@@ -214,9 +214,9 @@
215215 'mwe-upwiz-error-license-wikitext-too-long' => 'The wikitext you entered is too long.',
216216 'mwe-upwiz-error-license-wikitext-invalid' => 'This does not seem to be valid wikitext, or does not contain a license.',
217217 'mwe-upwiz-details-error-count' => 'There {{PLURAL:$1|is one error|are $1 errors}} with the {{PLURAL:$2|form|forms}} above. Correct the errors, and try submitting again.',
218 - 'mwe-upwiz-to-many-files-ok' => 'Ok',
219 - 'mwe-upwiz-to-many-files-text' => 'You can only upload $1 {{PLURAL:$1|file|files}} in one go. You tried to add $2 {{PLURAL:$2|file|files}}, so $3 {{PLURAL:$3|file|files}} have been omitted.',
220 - 'mwe-upwiz-to-many-files' => 'To many files',
 218+ 'mwe-upwiz-too-many-files-ok' => 'Ok',
 219+ 'mwe-upwiz-too-many-files-text' => 'You can only upload $1 {{PLURAL:$1|file|files}} in one go. You tried to add $2 {{PLURAL:$2|file|files}}, so $3 {{PLURAL:$3|file|files}} have been removed.',
 220+ 'mwe-upwiz-too-many-files' => 'Too many files',
221221
222222 /* LICENSES & combinations of licenses */
223223 /* may be a good idea to shift to WikimediaLicenseTexts? */
@@ -587,9 +587,9 @@
588588 'mwe-upwiz-prefs-def-3rdparty' => 'Form input label',
589589 'mwe-upwiz-prefs-def-license-ownwork' => 'Radio button option',
590590 'mwe-upwiz-prefs-def-license-3rdparty' => 'Radio button option',
591 - 'mwe-upwiz-to-many-files-ok' => 'Ok button text',
592 - 'mwe-upwiz-to-many-files-text' => 'Error message informing the user there are to manuy uploads in a dialog. Each param is a file count.',
593 - 'mwe-upwiz-to-many-files' => 'Error dialog title',
 591+ 'mwe-upwiz-too-many-files-ok' => 'Ok button text',
 592+ 'mwe-upwiz-too-many-files-text' => 'Error message informing the user there are to manuy uploads in a dialog. Each param is a file count.',
 593+ 'mwe-upwiz-too-many-files' => 'Error dialog title',
594594 );
595595
596596 /** Afrikaans (Afrikaans)
Index: trunk/extensions/UploadWizard/resources/mw.UploadWizardUpload.js
@@ -338,7 +338,7 @@
339339
340340 if ( tooManyFiles ) {
341341 var remainingFiles = mw.UploadWizard.config[ 'maxUploads' ] - _this.wizard.uploads.length;
342 - _this.showToManyFilesWarning( files.length - remainingFiles );
 342+ _this.showTooManyFilesWarning( files.length - remainingFiles );
343343 var files = remainingFiles > 1 ? files.slice( 1, remainingFiles - 1 ) : [];
344344 }
345345 else {
@@ -388,10 +388,10 @@
389389 * since they went over the max files limit.
390390 * @param {Integer}
391391 */
392 - showToManyFilesWarning: function( filesIgnored ) {
 392+ showTooManyFilesWarning: function( filesIgnored ) {
393393 var buttons = [
394394 {
395 - text: gM( 'mwe-upwiz-to-many-files-ok' ),
 395+ text: gM( 'mwe-upwiz-too-many-files-ok' ),
396396 click: function() {
397397 $( this ).dialog( "close" );
398398 }
@@ -399,7 +399,7 @@
400400 ];
401401 $j( '<div></div>' )
402402 .msg(
403 - 'mwe-upwiz-to-many-files-text',
 403+ 'mwe-upwiz-too-many-files-text',
404404 mw.UploadWizard.config[ 'maxUploads' ],
405405 mw.UploadWizard.config[ 'maxUploads' ] + filesIgnored,
406406 filesIgnored
@@ -408,7 +408,7 @@
409409 width: 500,
410410 zIndex: 200000,
411411 autoOpen: true,
412 - title: gM( 'mwe-upwiz-to-many-files' ),
 412+ title: gM( 'mwe-upwiz-too-many-files' ),
413413 modal: true,
414414 buttons: buttons
415415 } );

Follow-up revisions

RevisionCommit summaryAuthorDate
r104193Follow-up r104169: Correct capital usage and consistent punctuation.siebrand20:19, 24 November 2011
r105336wording change followup r104169neilk19:00, 6 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104167bug 31341, follow up to r104117jeroendedauw14:44, 24 November 2011

Status & tagging log