r104124 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104123‎ | r104124 | r104125 >
Date:01:26, 24 November 2011
Author:brion
Status:ok
Tags:
Comment:
Followup r103945: fix regression in XML export namespace formatting for namespaces with spaces in them (eg 'User talk')

The changes in r103945 for bug 32376, bug 31697 accidentally let underscore-forms through for the namespace portion, when we're supposed to have the space form. Causes problems with search indexing.
Modified paths:
  • /trunk/phase3/includes/Export.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Export.php
——@@ -692,7 +692,7 @@
693693 }
694694
695695 global $wgContLang;
696 - $prefix = $wgContLang->getNsText( $title->getNamespace() );
 696+ $prefix = str_replace( '_', ' ', $wgContLang->getNsText( $title->getNamespace() ) );
697697
698698 if ($prefix !== '') {
699699 $prefix .= ':';

Follow-up revisions

RevisionCommit summaryAuthorDate
r104125MFT r104124 (fixes XML export regression in r103945 / r103953 on branch)brion01:29, 24 November 2011
r104126MFT r104124 (fixes regression in r103945; r103954 on branch)brion01:29, 24 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103945* (bug 32376) XML export tweak to use canonical user namespaces instead of ge...brion19:33, 22 November 2011
r103953MFT r103945: use canonical user NS in export, workaround for search prefix bu...brion20:19, 22 November 2011
r103954MFT r103945: use canonical user NS in export, workaround for search prefix bu...brion20:20, 22 November 2011

Status & tagging log