| Index: trunk/phase3/RELEASE-NOTES-1.19 |
| — | — | @@ -155,6 +155,7 @@ |
| 156 | 156 | * (bug 1697) The way to search blocked usernames in block log should be clearer |
| 157 | 157 | * (bug 29747) eAccelerator shared memory caching has been removed since it is |
| 158 | 158 | now disabled by default and is buggy. APC, XCache and WinCache are not affected. |
| | 159 | +* Installer now refuses to install if php was not compiled with Ctype support |
| 159 | 160 | |
| 160 | 161 | === API changes in 1.19 === |
| 161 | 162 | * (bug 19838) siprop=interwikimap can now use the interwiki cache. |
| Index: trunk/phase3/includes/installer/Installer.php |
| — | — | @@ -107,6 +107,7 @@ |
| 108 | 108 | 'envCheckUploadsDirectory', |
| 109 | 109 | 'envCheckLibicu', |
| 110 | 110 | 'envCheckSuhosinMaxValueLength', |
| | 111 | + 'envCheckCtype', |
| 111 | 112 | ); |
| 112 | 113 | |
| 113 | 114 | /** |
| — | — | @@ -1070,6 +1071,13 @@ |
| 1071 | 1072 | } |
| 1072 | 1073 | } |
| 1073 | 1074 | |
| | 1075 | + protected function envCheckCtype() { |
| | 1076 | + if ( !function_exists( 'ctype_digit' ) ) { |
| | 1077 | + $this->showError( 'config-ctype' ); |
| | 1078 | + return false; |
| | 1079 | + } |
| | 1080 | + } |
| | 1081 | + |
| 1074 | 1082 | /** |
| 1075 | 1083 | * Get an array of likely places we can find executables. Check a bunch |
| 1076 | 1084 | * of known Unix-like defaults, as well as the PATH environment variable |
| Index: trunk/phase3/includes/installer/Installer.i18n.php |
| — | — | @@ -132,6 +132,7 @@ |
| 133 | 133 | 'config-memory-bad' => "'''Warning:''' PHP's <code>memory_limit</code> is $1. |
| 134 | 134 | This is probably too low. |
| 135 | 135 | The installation may fail!", |
| | 136 | + 'config-ctype' => "'''Fatal''': PHP must be compiled with support for the [http://www.php.net/manual/en/ctype.installation.php Ctype extension].", |
| 136 | 137 | 'config-xcache' => '[http://xcache.lighttpd.net/ XCache] is installed', |
| 137 | 138 | 'config-apc' => '[http://www.php.net/apc APC] is installed', |
| 138 | 139 | 'config-wincache' => '[http://www.iis.net/download/WinCacheForPhp WinCache] is installed', |
| — | — | @@ -603,6 +604,7 @@ |
| 604 | 605 | * $2 is the value to which <code>memory_limit</code> was raised.', |
| 605 | 606 | 'config-memory-bad' => 'Parameters: |
| 606 | 607 | * $1 is the configured <code>memory_limit</code>.', |
| | 608 | + 'config-ctype' => 'Message if support for [http://www.php.net/manual/en/ctype.installation.php Ctype] is missing from PHP', |
| 607 | 609 | 'config-xcache' => 'Message indicates if this program is available', |
| 608 | 610 | 'config-apc' => 'Message indicates if this program is available', |
| 609 | 611 | 'config-wincache' => 'Message indicates if this program is available', |