r104029 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104028‎ | r104029 | r104030 >
Date:13:12, 23 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Followup r101507: don't automatically use APC for the localization cache if it is available. I've expressed reservations in my CR comments (issues abound wherever maintenance scripts, server farms or manualRecache are involved), but the real reason is that three people (Siebrand on CR, Antoine/hashar in person and Rusty Burchfield on bug 32602) have reported problems with the APC LC, and had to set $wgLocalisationCacheConf['store'] = 'files'; explicitly to get LC to work again.
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
——@@ -163,12 +163,7 @@
164164 $storeClass = 'LCStore_Accel';
165165 break;
166166 case 'detect':
167 - try {
168 - $c = wfGetCache( CACHE_ACCEL );
169 - $storeClass = 'LCStore_Accel';
170 - } catch( Exception $c ) {
171 - $storeClass = $wgCacheDirectory ? 'LCStore_CDB' : 'LCStore_DB';
172 - }
 167+ $storeClass = $wgCacheDirectory ? 'LCStore_CDB' : 'LCStore_DB';
173168 break;
174169 default:
175170 throw new MWException(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101507Re-apply Vitaliy Filippov's patch from Bug #29283 with a modification...mah18:31, 1 November 2011

Comments

#Comment by Hashar (talk | contribs)   13:18, 23 November 2011

The problem I had with CACHE_ACCEL is that l10n cache somehow try to cache all the languages in memory and I end up with an out of memory error :(

Status & tagging log