r104027 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104026‎ | r104027 | r104028 >
Date:12:44, 23 November 2011
Author:robin
Status:resolved (Comments)
Tags:miscextensions 
Comment:
Add direction mark for bug 32600, and put number of pages in message as parameter 2.
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage.i18n.php (modified) (history)
  • /trunk/extensions/ProofreadPage/SpecialProofreadPages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage.i18n.php
@@ -60,7 +60,7 @@
6161 Remarks||10',
6262 'proofreadpage_default_header' => '',
6363 'proofreadpage_default_footer' => '<references/>',
64 - 'proofreadpage_pages' => "{{PLURAL:$1|page|pages}}",
 64+ 'proofreadpage_pages' => "$2 {{PLURAL:$1|page|pages}}",
6565 'proofreadpage_specialpage_text' => '',
6666 'proofreadpage_specialpage_legend' => 'Search index pages',
6767 'proofreadpage_source' => 'Source',
Index: trunk/extensions/ProofreadPage/SpecialProofreadPages.php
@@ -140,13 +140,12 @@
141141 $num_void = $size-$q1-$q2-$q3-$q4-$q0;
142142 $void_cell = $num_void ? "<td align=center style='border-style:dotted;background:#ffffff;border-width:1px;' width=\"{$num_void}\"></td>" : '';
143143
144 - // FIXME: consider using $size in 'proofreadpage_pages' instead of glueing it together in $output
145 - $pages = wfMsgExt( 'proofreadpage_pages', 'parsemag', $size );
146 - $size = $wgLang->formatNum( $size );
 144+ $dirmark = $wgLang->getDirMark();
 145+ $pages = wfMsgExt( 'proofreadpage_pages', 'parsemag', $size, $wgLang->formatNum( $size ) );
147146
148147 $output = "<table style=\"line-height:70%;\" border=0 cellpadding=5 cellspacing=0 >
149148 <tr valign=\"bottom\">
150 -<td style=\"white-space:nowrap;overflow:hidden;\">{$plink} [$size $pages]</td>
 149+<td style=\"white-space:nowrap;overflow:hidden;\">{$plink} $dirmark[$pages]</td>
151150 <td>
152151 <table style=\"line-height:70%;\" border=0 cellpadding=0 cellspacing=0 >
153152 <tr>

Follow-up revisions

RevisionCommit summaryAuthorDate
r109746Fix for r104027 - Put $dirmark inside curly braces so that it's interpreted s...zaran19:15, 22 January 2012

Comments

#Comment by Raymond (talk | contribs)   13:15, 23 November 2011

Please add message doc for the new parameter. Thanks.

#Comment by SPQRobin (talk | contribs)   13:18, 23 November 2011

Done at Translatewiki

#Comment by TheDJ (talk | contribs)   18:37, 22 January 2012

"$dirmark[$pages]" : dirmark[] is interpreted as an array now.

#Comment by Zaran (talk | contribs)   19:18, 22 January 2012

Fixed in r109746.

Status & tagging log