r103984 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103983‎ | r103984 | r103985 >
Date:00:03, 23 November 2011
Author:johnduhart
Status:resolved (Comments)
Tags:
Comment:
Followup r103814, fixed a few typos and a stray newline
Modified paths:
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -12,8 +12,7 @@
1313 * @ingroup Deployment
1414 * @since 1.17
1515 */
16 -class
17 -WebInstaller extends Installer {
 16+class WebInstaller extends Installer {
1817
1918 /**
2019 * @var WebInstallerOutput
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -158,7 +158,7 @@
159159 public function execute() {
160160 global $wgLang;
161161 $r = $this->parent->request;
162 - $userLang = $r->getVal( 'userlang' );
 162+ $userLang = $r->getVal( 'uselang' );
163163 $contLang = $r->getVal( 'ContLang' );
164164
165165 $lifetime = intval( ini_get( 'session.gc_maxlifetime' ) );
@@ -207,7 +207,7 @@
208208 }
209209 $this->startForm();
210210 $s = Html::hidden( 'LanguageRequestTime', time() ) .
211 - $this->getLanguageSelector( 'userlang', 'config-your-language', $userLang,
 211+ $this->getLanguageSelector( 'uselang', 'config-your-language', $userLang,
212212 $this->parent->getHelpBox( 'config-your-language-help' ) ) .
213213 $this->getLanguageSelector( 'ContLang', 'config-wiki-language', $contLang,
214214 $this->parent->getHelpBox( 'config-wiki-language-help' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r104321Followup r103984, take the default for the language dropdown from the URLjohnduhart22:50, 26 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103814Bug 28296 - Installer should honor &uselang= parameterjohnduhart15:30, 21 November 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   00:11, 23 November 2011

Ok, seems to work for setting the initial visible language, but it doesn't persist into the initial language selector. Should probably use this rather than English to fill out the default selections?

Screenshot installer language selector uselang problem.png

#Comment by Johnduhart (talk | contribs)   22:50, 26 November 2011

Ah, I didn't consider that. Fixed in r104321

Status & tagging log