r103941 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103940‎ | r103941 | r103942 >
Date:19:00, 22 November 2011
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
(bug 32586) Allow styling of message 'revreview-hist-pending-difflink'
Modified paths:
  • /trunk/extensions/FlaggedRevs/frontend/FlaggedRevsUI.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/frontend/modules/ext.flaggedRevs.basic.css (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/frontend/FlaggedRevsUI.hooks.php
——@@ -406,7 +406,7 @@
407407 $class = 'flaggedrevs-pending';
408408 $link = wfMsgExt( 'revreview-hist-pending-difflink', 'parseinline',
409409 $title->getPrefixedText(), $history->fr_stableRevId, $revId );
410 - $link = '<span class="plainlinks">' . $link . '</span>';
 410+ $link = '<span class="plainlinks mw-fr-hist-difflink">' . $link . '</span>';
411411 $history->fr_pendingRevs = true; // pending rev shown above stable
412412 // Reviewed revision: highlight and add link
413413 } elseif ( isset( $row->fr_quality ) ) {
——@@ -422,7 +422,7 @@
423423 # Style the row as needed
424424 if ( $class ) $s = "<span class='$class'>$s</span>";
425425 # Add stable old version link
426 - if ( $link ) $s .= " <small>$link</small>";
 426+ if ( $link ) $s .= " $link";
427427 return true;
428428 }
429429
Index: trunk/extensions/FlaggedRevs/frontend/modules/ext.flaggedRevs.basic.css
——@@ -301,6 +301,11 @@
302302 font-weight: bold;
303303 }
304304
 305+/* History items */
 306+.mw-fr-hist-difflink {
 307+ font-size: 85%;
 308+}
 309+
305310 /* Diff items */
306311 #mw-fr-diff-headeritems {
307312 direction: ltr;

Follow-up revisions

RevisionCommit summaryAuthorDate
r113090r103941: effectively restored some styling that was lost in history itemsaaron21:42, 5 March 2012

Comments

#Comment by Umherirrender (talk | contribs)   15:46, 2 March 2012

This removed the small also from the $link returned by markHistoryRow. It is possible to get the old style back?

Untested: 

/* History items */
.fr-hist-quality-auto,
.fr-hist-basic-auto,
.fr-hist-quality-user,
.fr-hist-basic-user,
.mw-fr-hist-difflink { 
	font-size: 85%; 
}
#Comment by Umherirrender (talk | contribs)   19:18, 6 March 2012

Was the remove of the small from the other links intended? Okay.

I have not read that explicit in the commit and people on de.wp was wondering about the bigger text, that why I have mark this as fixme.

#Comment by Aaron Schulz (talk | contribs)   19:19, 6 March 2012

No it wasn't intended, I don't think so at least. I changed the status because of r113090.

Status & tagging log