r103910 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103909‎ | r103910 | r103911 >
Date:16:04, 22 November 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow-up r103865. Accept lowercase hex and remove empty statement.
Modified paths:
  • /trunk/phase3/includes/libs/JavaScriptMinifier.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/JavaScriptMinifier.php
@@ -489,7 +489,7 @@
490490 ) {
491491 // Hex numeric literal
492492 $end++; // x or X
493 - $end += strspn( $s, '0123456789ABCDEF', $end );
 493+ $end += strspn( $s, '0123456789ABCDEFabcdef', $end );
494494 // @fixme if no hex digits, parse error
495495 } elseif(
496496 ctype_digit( $ch )
@@ -505,7 +505,7 @@
506506 }
507507 $exponent = strspn( $s, 'eE', $end );
508508 if( $exponent ) {
509 - $end += $exponent;;
 509+ $end += $exponent;
510510 // + sign is optional; - sign is required.
511511 $end += strspn( $s, '-+', $end );
512512 $end += strspn( $s, '0123456789', $end );

Follow-up revisions

RevisionCommit summaryAuthorDate
r103940Final fixup to r103910 and follow-ups....platonides18:56, 22 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103865* (bug 32548) fix minification bug when numeric literal with exponent was spl...brion23:16, 21 November 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:29, 22 November 2011

needs tests

#Comment by Brion VIBBER (talk | contribs)   23:15, 22 November 2011

don't think there'll be a clear diff here based on the other bugs it wouldn't/would see, so that's fine. :)

Status & tagging log