r103896 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103895‎ | r103896 | r103897 >
Date:14:37, 22 November 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
(bug 32412) TOC links on [[Special:EditWatchlist]] points to the fieldsets

Points the TOC entry to the fieldset element and add an id to those fieldset
using the same id prefix we used in 1.17 ('editwatchlist-')

This is a 1.18 regression.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialEditWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -35,6 +35,7 @@
3636 * (bug 29854) Store protocol-relative links twice in the externallinks table,
3737 one with http: in el_index and once with https.
3838 * (bug 31822) Error during upgrade due to output buffer reset in stdout.
 39+* (bug 32412) TOC links on [[Special:EditWatchlist]] points to the fieldsets
3940
4041 === Configuration changes in 1.18 ===
4142 * The WantedPages::getSQL hook has been removed and replaced with
Index: trunk/phase3/includes/specials/SpecialEditWatchlist.php
@@ -416,7 +416,7 @@
417417 $nsText = ($ns == NS_MAIN)
418418 ? wfMsgHtml( 'blanknamespace' )
419419 : htmlspecialchars( $wgContLang->getFormattedNsText( $ns ) );
420 - $this->toc .= Linker::tocLine( "mw-htmlform-{$data['section']}", $nsText,
 420+ $this->toc .= Linker::tocLine( "editwatchlist-{$data['section']}", $nsText,
421421 $this->getLanguage()->formatNum( ++$tocLength ), 1 ) . Linker::tocLineEnd();
422422 }
423423 $this->toc = Linker::tocList( $this->toc );
@@ -559,6 +559,9 @@
560560 ? wfMsgHtml( 'blanknamespace' )
561561 : htmlspecialchars( $this->getContext()->getLanguage()->getFormattedNsText( $namespace ) );
562562 }
 563+ public function getBody() {
 564+ return $this->displaySection( $this->mFieldTree, '', 'editwatchlist-' );
 565+ }
563566 }
564567
565568 class EditWatchlistCheckboxSeriesField extends HTMLMultiSelectField {

Follow-up revisions

RevisionCommit summaryAuthorDate
r103898MFT to REL1_18 r103896...hashar14:42, 22 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103894(bug 32412) TOC links on [[Special:EditWatchlist]] now points to the fieldsethashar14:21, 22 November 2011

Comments

#Comment by Hashar (talk | contribs)   14:42, 22 November 2011

Merged in REL1_18

Status & tagging log