r103866 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103865‎ | r103866 | r103867 >
Date:23:17, 21 November 2011
Author:jpostlethwaite
Status:ok
Tags:
Comment:
Removing unnecessary multiplication by 100.. See r103863..
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -1736,7 +1736,7 @@
17371737 // JPY cannot have cents.
17381738 $floorCurrencies = array ( 'JPY' );
17391739 if ( in_array( $this->staged_data['currency_code'], $floorCurrencies ) ) {
1740 - $this->staged_data['amount'] = floor( $this->staged_data['amount'] ) * 100;
 1740+ $this->staged_data['amount'] = floor( $this->staged_data['amount'] );
17411741 }
17421742
17431743 $this->staged_data['amount'] = $this->staged_data['amount'] * 100;

Follow-up revisions

RevisionCommit summaryAuthorDate
r103869MFT r103415, r103514, r103837, r103854, r103863, r103866khorn23:41, 21 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103863Simplifying process of flooring yen currency. See r103514.jpostlethwaite23:09, 21 November 2011

Status & tagging log