r103683 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103682‎ | r103683 | r103684 >
Date:16:19, 19 November 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Global tables died
Modified paths:
  • /trunk/phase3/maintenance/oracle/archives/patch-globalinterwiki.sql (deleted) (history)
  • /trunk/phase3/maintenance/oracle/archives/patch-globalnamespaces.sql (deleted) (history)
  • /trunk/phase3/maintenance/oracle/archives/patch-globaltemplatelinks.sql (deleted) (history)
  • /trunk/phase3/maintenance/oracle/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/oracle/archives/patch-globalinterwiki.sql
@@ -1,8 +0,0 @@
2 -define mw_prefix='{$wgDBprefix}';
3 -
4 -CREATE TABLE &mw_prefix.globalinterwiki (
5 - giw_wikiid VARCHAR2(64) NOT NULL,
6 - giw_prefix VARCHAR2(32) NOT NULL
7 -);
8 -CREATE UNIQUE INDEX &mw_prefix.globalinterwiki_u01 ON &mw_prefix.globalinterwiki (giw_wikiid, giw_prefix);
9 -
Index: trunk/phase3/maintenance/oracle/archives/patch-globaltemplatelinks.sql
@@ -1,15 +0,0 @@
2 -define mw_prefix='{$wgDBprefix}';
3 -
4 -CREATE TABLE &mw_prefix.globaltemplatelinks (
5 - gtl_from_wiki VARCHAR2(64) NOT NULL,
6 - gtl_from_page NUMBER NOT NULL,
7 - gtl_from_namespace NUMBER NOT NULL,
8 - gtl_from_title VARCHAR2(255) NOT NULL,
9 - gtl_to_prefix VARCHAR2(32) NOT NULL,
10 - gtl_to_namespace NUMBER NOT NULL,
11 - gtl_to_namespacetext VARCHAR2(255) NOT NULL,
12 - gtl_to_title VARCHAR2(255) NOT NULL
13 -);
14 -CREATE UNIQUE INDEX &mw_prefix.globaltemplatelinks_u01 ON &mw_prefix.globaltemplatelinks (gtl_to_prefix, gtl_to_namespace, gtl_to_title, gtl_from_wiki, gtl_from_page);
15 -CREATE UNIQUE INDEX &mw_prefix.globaltemplatelinks_u02 ON &mw_prefix.globaltemplatelinks (gtl_from_wiki, gtl_from_page, gtl_to_prefix, gtl_to_namespace, gtl_to_title);
16 -
Index: trunk/phase3/maintenance/oracle/archives/patch-globalnamespaces.sql
@@ -1,9 +0,0 @@
2 -define mw_prefix='{$wgDBprefix}';
3 -
4 -CREATE TABLE &mw_prefix.globalnamespaces (
5 - gn_wiki VARCHAR2(64) NOT NULL,
6 - gn_namespace NUMBER NOT NULL,
7 - gn_namespacetext VARCHAR2(255) NOT NULL
8 -);
9 -CREATE UNIQUE INDEX &mw_prefix.globalnamespaces_u01 ON &mw_prefix.globalnamespaces (gn_wiki, gn_namespace, gn_namespacetext);
10 -
Index: trunk/phase3/maintenance/oracle/tables.sql
@@ -31,7 +31,7 @@
3232
3333 CREATE TABLE &mw_prefix.user_groups (
3434 ug_user NUMBER DEFAULT 0 NOT NULL,
35 - ug_group VARCHAR2(16) NOT NULL
 35+ ug_group VARCHAR2(32) NOT NULL
3636 );
3737 ALTER TABLE &mw_prefix.user_groups ADD CONSTRAINT &mw_prefix.user_groups_fk1 FOREIGN KEY (ug_user) REFERENCES &mw_prefix.mwuser(user_id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED;
3838 CREATE UNIQUE INDEX &mw_prefix.user_groups_u01 ON &mw_prefix.user_groups (ug_user,ug_group);
@@ -518,7 +518,7 @@
519519 tb_title VARCHAR2(255) NOT NULL,
520520 tb_url VARCHAR2(255) NOT NULL,
521521 tb_ex CLOB,
522 - tb_name VARCHAR2(255)
 522+ tb_name VARCHAR2(255)
523523 );
524524 ALTER TABLE &mw_prefix.trackbacks ADD CONSTRAINT &mw_prefix.trackbacks_pk PRIMARY KEY (tb_id);
525525 ALTER TABLE &mw_prefix.trackbacks ADD CONSTRAINT &mw_prefix.trackbacks_fk1 FOREIGN KEY (tb_page) REFERENCES &mw_prefix.page(page_id) ON DELETE CASCADE DEFERRABLE INITIALLY DEFERRED;
@@ -677,34 +677,8 @@
678678 cf_value blob NOT NULL
679679 );
680680 ALTER TABLE &mw_prefix.config ADD CONSTRAINT &mw_prefix.config_pk PRIMARY KEY (cf_name);
 681+-- leaving index out for now ...
681682
682 -CREATE TABLE &mw_prefix.globaltemplatelinks (
683 - gtl_from_wiki VARCHAR2(64) NOT NULL,
684 - gtl_from_page NUMBER NOT NULL,
685 - gtl_from_namespace NUMBER NOT NULL,
686 - gtl_from_title VARCHAR2(255) NOT NULL,
687 - gtl_to_prefix VARCHAR2(32) NOT NULL,
688 - gtl_to_namespace NUMBER NOT NULL,
689 - gtl_to_namespacetext VARCHAR2(255) NOT NULL,
690 - gtl_to_title VARCHAR2(255) NOT NULL
691 -);
692 -CREATE UNIQUE INDEX &mw_prefix.globaltemplatelinks_u01 ON &mw_prefix.globaltemplatelinks (gtl_to_prefix, gtl_to_namespace, gtl_to_title, gtl_from_wiki, gtl_from_page);
693 -CREATE UNIQUE INDEX &mw_prefix.globaltemplatelinks_u02 ON &mw_prefix.globaltemplatelinks (gtl_from_wiki, gtl_from_page, gtl_to_prefix, gtl_to_namespace, gtl_to_title);
694 -
695 -CREATE TABLE &mw_prefix.globalnamespaces (
696 - gn_wiki VARCHAR2(64) NOT NULL,
697 - gn_namespace NUMBER NOT NULL,
698 - gn_namespacetext VARCHAR2(255) NOT NULL
699 -);
700 -CREATE UNIQUE INDEX &mw_prefix.globalnamespaces_u01 ON &mw_prefix.globalnamespaces (gn_wiki, gn_namespace, gn_namespacetext);
701 -
702 -CREATE TABLE &mw_prefix.globalinterwiki (
703 - giw_wikiid VARCHAR2(64) NOT NULL,
704 - giw_prefix VARCHAR2(32) NOT NULL
705 -);
706 -CREATE UNIQUE INDEX &mw_prefix.globalinterwiki_u01 ON &mw_prefix.globalinterwiki (giw_wikiid, giw_prefix);
707 -
708683 -- do not prefix this table as it breaks parserTests
709684 CREATE TABLE wiki_field_info_full (
710685 table_name VARCHAR2(35) NOT NULL,
@@ -713,9 +687,9 @@
714688 data_length NUMBER NOT NULL,
715689 data_type VARCHAR2(106),
716690 not_null CHAR(1) NOT NULL,
717 -prim NUMBER(1),
 691+prim NUMBER(1),
718692 uniq NUMBER(1),
719 -nonuniq NUMBER(1)
 693+nonuniq NUMBER(1)
720694 );
721695 ALTER TABLE wiki_field_info_full ADD CONSTRAINT wiki_field_info_full_pk PRIMARY KEY (table_name, column_name);
722696

Comments

#Comment by Reedy (talk | contribs)   16:24, 19 November 2011

Includes a change for bug 32470 which will be committed soon

Status & tagging log