r103621 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103620‎ | r103621 | r103622 >
Date:22:32, 18 November 2011
Author:seanheavey
Status:deferred (Comments)
Tags:
Comment:
changes for fabrice's request yesterday
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -262,8 +262,9 @@
263263 }
264264 if ( $( this ).val() == def_msg ) {
265265 $( this ).val( '' );
 266+ $(this).addClass( 'active' );
266267 }
267 - $(this).addClass( 'active' );
 268+
268269 })
269270 .blur( function () {
270271 var def_msg = '';
@@ -275,7 +276,8 @@
276277 }
277278 if ( $( this ).val() == '' ) {
278279 $( this ).val( def_msg );
279 - }
 280+ $(this).removeClass( 'active' );
 281+ }
280282 } );
281283
282284

Comments

#Comment by Johnduhart (talk | contribs)   00:10, 19 November 2011

Can we please use more descriptive commit messages?

Status & tagging log