r103495 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103494‎ | r103495 | r103496 >
Date:19:17, 17 November 2011
Author:bsitu
Status:ok (Comments)
Tags:
Comment:
follow up to r103251, use date() and time() instead of userDate() and userTime() since these functions are not in release branch yet
Modified paths:
  • /trunk/extensions/MoodBar/SpecialFeedbackDashboard.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/SpecialFeedbackDashboard.php
@@ -250,7 +250,7 @@
251251 * @return string HTML
252252 */
253253 protected static function getHiddenFooter( $feedbackItem, $mode ) {
254 - global $wgLang, $wgUser;
 254+ global $wgLang;
255255
256256 $id = $feedbackItem->getProperty('id');
257257 $permalinkTitle = SpecialPage::getTitleFor( 'FeedbackDashboard', $id );
@@ -262,12 +262,11 @@
263263 $link = Xml::tags( 'span', array( 'class' => 'fbd-item-restore' ), "($link)" );
264264
265265 $feedback_hidden_detail = self::getFeedbackHiddenDetail($id);
266 - $timestamp = wfTimestamp( TS_DB, $feedback_hidden_detail->log_timestamp );
267266
268267 $footer = wfMessage('moodbar-hidden-footer')->
269268 rawParams( htmlspecialchars( $feedback_hidden_detail->log_user_text ),
270 - $wgLang->userDate($timestamp, $wgUser),
271 - $wgLang->userTime($timestamp, $wgUser),
 269+ $wgLang->date($feedback_hidden_detail->log_timestamp),
 270+ $wgLang->time($feedback_hidden_detail->log_timestamp),
272271 htmlspecialchars( $feedback_hidden_detail->log_comment ),
273272 $link )->escaped();
274273 return Xml::tags( 'div', array( 'class' => 'error' ), $footer );

Sign-offs

UserFlagDate
Robmoeninspected19:42, 17 November 2011
Robmoentested19:42, 17 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103251Adding text to indicate which admin at what time hid a feedback along with re...bsitu22:45, 15 November 2011

Comments

#Comment by Robmoen (talk | contribs)   19:42, 17 November 2011

Looks good.

#Comment by Johnduhart (talk | contribs)   04:21, 18 November 2011

In the future, please mark it as such on the status.

Status & tagging log