r103453 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103452‎ | r103453 | r103454 >
Date:10:50, 17 November 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Move extension credits to the top
Modified paths:
  • /trunk/extensions/Narayam/Narayam.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/Narayam.php
@@ -27,6 +27,15 @@
2828 exit( 1 );
2929 }
3030
 31+$wgExtensionCredits['other'][] = array(
 32+ 'path' => __FILE__,
 33+ 'name' => 'Narayam',
 34+ 'version' => 0.1,
 35+ 'author' => array( 'Junaid P V (http://junaidpv.in)', 'Roan Kattouw' ),
 36+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Narayam',
 37+ 'descriptionmsg' => 'narayam-desc'
 38+);
 39+
3140 /* Configuration */
3241
3342 // Whether the input method should be active as default or not
@@ -96,16 +105,6 @@
97106
98107 $dir = dirname( __FILE__ );
99108
100 -// Register extension credits
101 -$wgExtensionCredits['other'][] = array(
102 - 'path' => __FILE__,
103 - 'name' => 'Narayam',
104 - 'version' => 0.1,
105 - 'author' => array( 'Junaid P V (http://junaidpv.in)', 'Roan Kattouw' ),
106 - 'url' => 'http://www.mediawiki.org/wiki/Extension:Narayam',
107 - 'descriptionmsg' => 'narayam-desc'
108 -);
109 -
110109 // Localization
111110 $wgExtensionMessagesFiles['Narayam'] = $dir . '/Narayam.i18n.php';
112111

Follow-up revisions

RevisionCommit summaryAuthorDate
r104218Change the link of author to external link instead of giving in brackets....santhosh04:20, 25 November 2011

Comments

#Comment by P858snake (talk | contribs)   11:03, 17 November 2011
+	'author' => array( 'Junaid P V ([http://junaidpv.in)', http://junaidpv.in)',] 'Roan Kattouw' ),

I'm pretty sure (but don't quote me) that the norm for people that want links there, is that they should be done as a external link for the person name (instead of sticking it in brackets after)

Status & tagging log