r103411 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103410‎ | r103411 | r103412 >
Date:23:31, 16 November 2011
Author:jpostlethwaite
Status:ok (Comments)
Tags:
Comment:
Adding eWallets to GlobalCollectGateway.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php
@@ -122,18 +122,6 @@
123123 }
124124
125125 }
126 - elseif ( $payment_method == 'rtbt' ) {
127 -
128 - $this->adapter->do_transaction( 'INSERT_ORDERWITHPAYMENT' );
129 -
130 - $formAction = $this->adapter->getTransactionDataFormAction();
131 -
132 - // Redirect to the bank
133 - if ( !empty( $formAction ) ) {
134 - return $wgOut->redirect( $formAction );
135 - }
136 -
137 - }
138126 elseif ( $payment_method == 'dd' ) {
139127
140128 $this->adapter->do_transaction( 'DO_BANKVALIDATION' );
@@ -148,7 +136,18 @@
149137 // Attach the error messages to the form
150138 $this->adapter->setBankValidationErrors();
151139 }
 140+ }
 141+ elseif ( $payment_method == 'ew' ) {
 142+
 143+ $this->adapter->do_transaction( 'INSERT_ORDERWITHPAYMENT' );
 144+
 145+ $formAction = $this->adapter->getTransactionDataFormAction();
152146
 147+ // Redirect to the bank
 148+ if ( !empty( $formAction ) ) {
 149+ return $wgOut->redirect( $formAction );
 150+ }
 151+
153152 }
154153 elseif ( $payment_method == 'obt' ) {
155154
@@ -160,6 +159,18 @@
161160 }
162161
163162 }
 163+ elseif ( $payment_method == 'rtbt' ) {
 164+
 165+ $this->adapter->do_transaction( 'INSERT_ORDERWITHPAYMENT' );
 166+
 167+ $formAction = $this->adapter->getTransactionDataFormAction();
 168+
 169+ // Redirect to the bank
 170+ if ( !empty( $formAction ) ) {
 171+ return $wgOut->redirect( $formAction );
 172+ }
 173+
 174+ }
164175 else {
165176 $this->adapter->do_transaction( 'INSERT_ORDERWITHPAYMENT' );
166177 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r103413Adding descriptor field for eWallets.jpostlethwaite23:33, 16 November 2011
r103415Added eWallets: cashU, Moneybookers, PayPal and WebMoney.jpostlethwaite23:35, 16 November 2011
r103847MFT r102338, r102681, r102685, r102810, r102828, r102829, r102832, r102836, r...khorn22:30, 21 November 2011
r103848MFT r102338, r102681, r102685, r102810, r102828, r102829, r102832, r102836, r...khorn22:31, 21 November 2011

Comments

#Comment by Jpostlethwaite (talk | contribs)   23:32, 16 November 2011

I also alphabetized the payment methods. Must have order!

Status & tagging log