r103352 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103351‎ | r103352 | r103353 >
Date:18:58, 16 November 2011
Author:seanheavey
Status:deferred (Comments)
Tags:
Comment:
Initial changes to feedback form copy.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit-disable.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -30,8 +30,7 @@
3131 'articlefeedbackv5-survey-disclaimerlink' => 'terms',
3232 /* ext.articleFeedbackv5 and jquery.articleFeedbackv5 */
3333 /* START Messages needing translation */
34 - 'articlefeedbackv5-bucket1-title' => 'What do $1 think?',
35 - 'articlefeedbackv5-bucket1-title-emphasis' => 'you',
 34+ 'articlefeedbackv5-bucket1-title' => 'Help improve this article',
3635 'articlefeedbackv5-bucket1-tooltip-title' => 'What is This?',
3736 'articlefeedbackv5-bucket1-tooltip-info' => 'Wikipedia\'s new Article Feedback system is designed to help you help us. We need your input to make Wikipedia the best encyclopedia in the world.',
3837 'articlefeedbackv5-bucket1-tooltip-linktext' => 'Learn more about Article Feedback',
@@ -5203,7 +5202,7 @@
52045203 Hilsen {{SITENAME}}-teamet',
52055204 );
52065205
5207 -/** Oriya (ଓଡ଼ିଆ)
 5206+/** Oriya (ଓଡ଼ିଆ)
52085207 * @author Odisha1
52095208 */
52105209 $messages['or'] = array(
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit-disable.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit-disable.png
___________________________________________________________________
Added: svn:mime-type
52115210 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -405,8 +405,6 @@
406406 color: #777777;
407407 }
408408 /*---===<<< Sean's Version 5 Styles >>>===---*/
409 -@charset "UTF-8";
410 -/* CSS Document */
411409 .clear {
412410 display: block;
413411 height: 0;
@@ -425,28 +423,100 @@
426424 padding:25px;
427425 color:#fff;
428426 }
429 -.articleFeedback {}
430 -.atf5 .articleFeedback-panel {
 427+.articleFeedbackv5-panel {
431428 width: 598px;
432429 background: #f5faff;
433430 border: 1px solid #ccc;
434431 color: #000;
435432 }
436 -.atf5 .articleFeedback-panel .articleFeedback-buffer {
 433+.articleFeedbackv5-panel .articleFeedback-buffer {
437434 padding: 20px;
438435 }
439 -.atf5 h2 {
 436+.articleFeedbackv5-panel h2 {
440437 float: left;
 438+ border: none;
441439 }
442 -.atf5 .trigger {
 440+.articleFeedbackv5-panel .trigger {
443441 display: block;
444442 height: 27px;
445443 width: 26px;
446444 background: url(images/bg-tooltip-trigger.png) no-repeat;
447 - cursor: pointer;
448445 float: right;
449446 position: relative;
450447 }
451 -.atf5 .trigger:hover {
 448+.articleFeedbackv5-panel .trigger:hover {
452449 background: url(images/bg-tooltip-trigger-hov.png) no-repeat;
 450+ cursor: pointer;
 451+ text-decoration: none;
 452+}
 453+.articleFeedbackv5-panel .button-placeholder {
 454+ display: inline-block;
 455+ height: 20px;
 456+ width: 50px;
 457+ text-align: center;
 458+ color: #fff;
 459+ text-shadow: 1px 1px 1px #000;
 460+ background: url(images/bg-button-disable.png) repeat-x;
 461+ -moz-border-radius: 3px;
 462+ -webkit-border-radius: 3px;
 463+ border-radius: 3px; /* future proofing */
 464+ -khtml-border-radius: 3px; /* for old Konqueror browsers */
 465+}
 466+.articleFeedbackv5-panel .instructions-left {
 467+ float:left;
 468+ margin: 0 15px 0 0;
 469+}
 470+.articleFeedbackv5-panel .buttons {
 471+ float: left;
 472+}
 473+.articleFeedbackv5-panel .buttons .form-item {
 474+ float: left;
 475+ margin: 0 15px 0 0;
 476+}
 477+.articleFeedbackv5-panel .buttons label,
 478+.articleFeedbackv5-panel .buttons input {
 479+ display: none;
 480+}
 481+.articleFeedbackv5-panel .buttons .button-placeholder:hover {
 482+ background: url(images/bg-button.png) repeat-x;
 483+ cursor: pointer;
 484+}
 485+.articleFeedbackv5-panel .buttons .button-placeholder-active {
 486+ background: url(images/bg-button.png) repeat-x;
 487+}
 488+.articleFeedbackv5-panel .feedback-text {
 489+ resize: none;
 490+ background: #fff;
 491+ border: 1px solid #000;
 492+ width: 518px;
 493+ height: 68px;
 494+ overflow: hidden;
 495+ padding: 10px;
 496+ font-size: 14px;
 497+ font: sans-serif;
 498+}
 499+.articleFeedbackv5-panel .articleFeedback-disclosure {
 500+ float: left;
 501+ width: 235px;
 502+ margin: 0 0 0 10px;
 503+}
 504+.articleFeedbackv5-panel .articleFeedback-submit {
 505+ float: right;
 506+ height: 25px;
 507+ width: 200px;
 508+ text-align: center;
 509+ background: url(images/bg-submit-disable.png) repeat-x !important;
 510+ margin: 10px 53px 0 0 !important;
 511+ border: none !important;
 512+ -moz-border-radius: 3px;
 513+ -webkit-border-radius: 3px;
 514+ border-radius: 3px; /* future proofing */
 515+ -khtml-border-radius: 3px; /* for old Konqueror browsers */
 516+}
 517+.articleFeedbackv5-panel .articleFeedback-submit span {
 518+ font-size: 16px;
 519+ line-height: 15px;
 520+ text-align: center;
 521+ color: #fff;
 522+ text-shadow: 1px 1px 1px #000;
453523 }
\ No newline at end of file
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -132,7 +132,7 @@
133133 var block_tpl = '\
134134 <form>\
135135 <div class="title-wrap">\
136 - <h2 class="articleFeedbackv5-title"></h2>\
 136+ <h2 class="articleFeedbackv5-title"><html:msg key="bucket1-title" /></h2>\
137137 <a class="articleFeedbackv5-tooltip-trigger">?</a>\
138138 <div class="articleFeedbackv5-tooltip">\
139139 <div class="tooltip-top"></div>\
@@ -173,15 +173,7 @@
174174 ';
175175 // Start up the block to return
176176 var $block = $( block_tpl );
177 -
178 - // Set the title with emphasis
179 - $block.find('.articleFeedbackv5-title').
180 - html( function () {
181 - var em = mw.html.element( 'em', {}, mw.msg( 'articlefeedbackv5-bucket1-title-emphasis' ) );
182 - return mw.html.escape( mw.msg( 'articlefeedbackv5-bucket1-title' ) )
183 - .replace( /\$1/, em.toString() );
184 - } );
185 -
 177+
186178 // Start out the tooltip hidden
187179 $block.find( '.articleFeedbackv5-tooltip' ).hide();
188180
Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.hooks.php
@@ -61,7 +61,6 @@
6262 'styles' => 'jquery.articleFeedbackv5/jquery.articleFeedbackv5.css',
6363 'messages' => array(
6464 'articlefeedbackv5-bucket1-title',
65 - 'articlefeedbackv5-bucket1-title-emphasis',
6665 'articlefeedbackv5-bucket1-tooltip-title',
6766 'articlefeedbackv5-bucket1-tooltip-info',
6867 'articlefeedbackv5-bucket1-tooltip-linktext',

Comments

#Comment by P858snake (talk | contribs)   11:24, 17 November 2011

Mime type on the png file addition

Status & tagging log