r103345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103344‎ | r103345 | r103346 >
Date:18:17, 16 November 2011
Author:tparscal
Status:deferred
Tags:
Comment:
Fixed incorrect symbolic name being used for nodeRules registration on tableCell and tableRow model nodes. Roan noticed this in r103211
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/models/es.TableCellModel.js (modified) (history)
  • /trunk/extensions/VisualEditor/modules/es/models/es.TableRowModel.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/models/es.TableRowModel.js
@@ -28,7 +28,7 @@
2929
3030 es.DocumentModel.nodeModels.tableRow = es.TableRowModel;
3131
32 -es.DocumentModel.nodeRules.listItem = {
 32+es.DocumentModel.nodeRules.tableRow = {
3333 'parents': ['table'],
3434 'children': ['tableCell'],
3535 'droppable': true
Index: trunk/extensions/VisualEditor/modules/es/models/es.TableCellModel.js
@@ -28,7 +28,7 @@
2929
3030 es.DocumentModel.nodeModels.tableCell = es.TableCellModel;
3131
32 -es.DocumentModel.nodeRules.listItem = {
 32+es.DocumentModel.nodeRules.tableCell = {
3333 'parents': ['tableRow'],
3434 'children': null,
3535 'droppable': false

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103211Added a "droppable" bit to each model so that prepareRemoval can avoid droppi...tparscal19:01, 15 November 2011

Status & tagging log