r103344 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103343‎ | r103344 | r103345 >
Date:17:58, 16 November 2011
Author:j
Status:ok
Tags:
Comment:
Always use closest even size:
If source dimensions are uneven, derivates
could end up with a green line at the bottom.
Modified paths:
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php
@@ -637,17 +637,17 @@
638638 if ( $sourceHeight > $maxSize['height'] ) {
639639 $targetHeight = $maxSize['height'];
640640 $targetWidth = intval( $targetHeight * $sourceAspect );
641 - //some players do not like uneven frame sizes
642 - $targetWidth += $targetWidth%2;
643641 }
644642 } else {
645643 if ( $sourceWidth > $maxSize['width'] ) {
646644 $targetWidth = $maxSize['width'];
647645 $targetHeight = intval( $targetWidth / $sourceAspect );
648646 //some players do not like uneven frame sizes
649 - $targetHeight += $targetHeight%2;
650647 }
651648 }
 649+ //some players do not like uneven frame sizes
 650+ $targetWidth += $targetWidth%2;
 651+ $targetHeight += $targetHeight%2;
652652 return array( $targetWidth, $targetHeight );
653653 }
654654 /**

Status & tagging log