r103339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103338‎ | r103339 | r103340 >
Date:16:53, 16 November 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
On errors not using OutputPage, Content-Type header wasn't set,
although we output localised UTF-8 messaged.
Modified paths:
  • /trunk/phase3/includes/Exception.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Exception.php
——@@ -181,6 +181,7 @@
182182
183183 $wgOut->output();
184184 } else {
 185+ header( "Content-Type: text/html; charset=utf-8" );
185186 $hookResult = $this->runHooks( get_class( $this ) . "Raw" );
186187 if ( $hookResult ) {
187188 die( $hookResult );

Comments

#Comment by Platonides (talk | contribs)   16:57, 16 November 2011

Note: DBConnectionError overrides useOutputPage() by always returning false

Status & tagging log