r103257 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103256‎ | r103257 | r103258 >
Date:23:24, 15 November 2011
Author:seanheavey
Status:deferred (Comments)
Tags:
Comment:
First upload of Option1 markup
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-disable.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-bottom.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-top.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-trigger-hov.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-trigger.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -130,35 +130,45 @@
131131 // The overall template
132132 var block_tpl = '\
133133 <form>\
134 - <div class="articleFeedbackv5-title"><html:msg key="bucket1-title" /></div>\
135 - <div style="clear:both;"></div>\
136 - <div class="articleFeedbackv5-bucket1-toggle">\
137 - <div class="articleFeedbackv5-question"><html:msg key="bucket1-question-toggle" /></div>\
138 - <div style="clear:both;"></div>\
139 - <input type="radio" name="toggle" value="yes" id="articleFeedbackv5-bucket1-toggle-yes" />\
140 - <label class="articleFeedbackv5-bucket1-toggle-found" for="articleFeedbackv5-bucket1-toggle-yes"><html:msg key="bucket1-toggle-found-yes" /></label>\
141 - <input type="radio" name="toggle" value="no" id="articleFeedbackv5-bucket1-toggle-no" />\
142 - <label class="articleFeedbackv5-bucket1-toggle-found" for="articleFeedbackv5-bucket1-toggle-no"><html:msg key="bucket1-toggle-found-no" /></label>\
 134+ <div class="title-wrap">\
 135+ <h2>What do <em>you</em> think?</h2>\
 136+ <a class="trigger">&nbsp;</a>\
 137+ <script type="text/javascript" language="javascript">\
 138+ $(".articleFeedback a.trigger").tooltip();\
 139+ </script>\
 140+ <div class="tooltip">\
 141+ <div class="tooltip-top"></div>\
 142+ <div class="tooltip-repeat">\
 143+ <h3>What is This?</h3>\
 144+ <p>Wikipedia’s new Article Feedback system is designed to help you help us. We need your input to make Wikipedia the best encyclopedia in the world.</p>\
 145+ <p><a target="_blank" href="#">Learn more about Article Feedback</a></p>\
 146+ </div>\
 147+ <div class="tooltip-bottom"></div>\
143148 </div>\
144 - <div style="clear:both;"></div>\
145 - <div class="articleFeedbackv5-comment">\
146 - <textarea name="comment"></textarea>\
147 - </div>\
148 - <div style="clear:both;"></div>\
149 - <div class="articleFeedbackv5-feedback-terms-info">\
150 - <div class="articleFeedbackv5-feedback"></div>\
151 - <div class="articleFeedbackv5-terms"></div>\
152 - </div>\
153 - <button class="articleFeedbackv5-submit" type="submit" disabled="disabled"><html:msg key="bucket1-form-submit" /></button>\
154 - <div class="articleFeedbackv5-success"><span><html:msg key="bucket1-form-success" /></span></div>\
155 - <div class="articleFeedbackv5-pending"><span><html:msg key="bucket1-form-pending" /></span></div>\
156 - <div style="clear:both;"></div>\
157 - <div class="articleFeedbackv5-notices">\
158 - <div class="articleFeedbackv5-expiry">\
159 - <div class="articleFeedbackv5-expiry-title"><html:msg key="form-panel-expiry-title" /></div>\
160 - <div class="articleFeedbackv5-expiry-message"><html:msg key="form-panel-expiry-message" /></div>\
 149+ <div class="clear"></div>\
 150+ </div>\
 151+ <div class="form-row">\
 152+ <p class="instructions-left">Did you find what you were looking for?</p>\
 153+ <div class="buttons">\
 154+ <div class="form-item">\
 155+ <label for="find-yes">Yes, I found what I was looking for.</label>\
 156+ <span class="button-placeholder">Yes</span>\
 157+ <input type="radio" name="find" id="find-yes" class="query-button" />\
161158 </div>\
 159+ <div class="form-item">\
 160+ <label for="find-no">No, I did not find what I was looking for.</label>\
 161+ <span class="button-placeholder">No.</span>\
 162+ <input type="radio" id="find-now" class="query-button last" />\
 163+ </div>\
 164+ <div class="clear"></div>\
162165 </div>\
 166+ </div>\
 167+ <textarea id="find-feedback" class="feedback-text">How can we improve this Article?</textarea>\
 168+ <div class="articleFeedback-disclosure">\
 169+ <p>Your Feedback will be shared <a href="#" target="_blank">here</a>. Seee our <a target="_blank" href="#">privacy policy</a> for more details.</p>\
 170+ </div>\
 171+ <button class="articleFeedback-submit articleFeedback-visibleWith-form ui-button ui-widget ui-state-default ui-corner-all ui-button-disabled ui-state-disabled ui-button-text-only ui-button-blue" type="submit" disabled="disabled" role="button" aria-disabled="true"><span class="ui-button-text">Submit Your Feedback</span></button>\
 172+ <div class="clear"></div>\
163173 </form>\
164174 ';
165175 // Start up the block to return
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-submit.png
___________________________________________________________________
Added: svn:mime-type
166176 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button.png
___________________________________________________________________
Added: svn:mime-type
167177 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-disable.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-disable.png
___________________________________________________________________
Added: svn:mime-type
168178 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-trigger-hov.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-trigger-hov.png
___________________________________________________________________
Added: svn:mime-type
169179 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip.png
___________________________________________________________________
Added: svn:mime-type
170180 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-top.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-top.png
___________________________________________________________________
Added: svn:mime-type
171181 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-trigger.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-trigger.png
___________________________________________________________________
Added: svn:mime-type
172182 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-bottom.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tooltip-bottom.png
___________________________________________________________________
Added: svn:mime-type
173183 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -404,3 +404,49 @@
405405 padding-left: 28px;
406406 color: #777777;
407407 }
 408+/*---===<<< Sean's Version 5 Styles >>>===---*/
 409+@charset "UTF-8";
 410+/* CSS Document */
 411+.clear {
 412+ display: block;
 413+ height: 0;
 414+ overflow: hidden;
 415+ clear: both;
 416+ float: none;
 417+ width: 100%;
 418+}
 419+/* tooltip styling. by default the element to be styled is .tooltip */
 420+.tooltip {
 421+ display:none;
 422+ background: #0F0;
 423+ font-size:12px;
 424+ height:70px;
 425+ width:160px;
 426+ padding:25px;
 427+ color:#fff;
 428+}
 429+.articleFeedback {}
 430+.atf5 .articleFeedback-panel {
 431+ width: 598px;
 432+ background: #f5faff;
 433+ border: 1px solid #ccc;
 434+ color: #000;
 435+}
 436+.atf5 .articleFeedback-panel .articleFeedback-buffer {
 437+ padding: 20px;
 438+}
 439+.atf5 h2 {
 440+ float: left;
 441+}
 442+.atf5 .trigger {
 443+ display: block;
 444+ height: 27px;
 445+ width: 26px;
 446+ background: url(images/bg-tooltip-trigger.png) no-repeat;
 447+ cursor: pointer;
 448+ float: right;
 449+ position: relative;
 450+}
 451+.atf5 .trigger:hover {
 452+ background: url(images/bg-tooltip-trigger-hov.png) no-repeat;
 453+}
\ No newline at end of file

Comments

#Comment by P858snake (talk | contribs)   11:23, 17 November 2011

Mimetype on the png files.

Status & tagging log