r103230 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103229‎ | r103230 | r103231 >
Date:21:47, 15 November 2011
Author:rmoen
Status:ok (Comments)
Tags:
Comment:
fixed bug for reason
Modified paths:
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.js
——@@ -304,8 +304,7 @@
305305 'action' : 'feedbackdashboard',
306306 'token' : mw.user.tokens.get('editToken'),
307307 'item' : item_id,
308 - 'format' : 'json',
309 - 'reason' : reason
 308+ 'format' : 'json'
310309 }, params ),
311310 function(response) {
312311 if ( response && response.feedbackdashboard ) {

Comments

#Comment by Raindrift (talk | contribs)   00:39, 16 November 2011

Don't be afraid of leaving verbose commit messages. I can see what you're doing here, kinda, but without more context it doesn't really make much sense.

#Comment by Robmoen (talk | contribs)   08:09, 16 November 2011

I moved the location of where reason gets set, and forgot to remove it in the params here. For some reason my code worked locally, and benny called me on it. I quickly revised and didn't leave a proper note. I'll do better of this going forward. Thanks for being gentle.

Status & tagging log