r103197 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103196‎ | r103197 | r103198 >
Date:17:26, 15 November 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
missing TEX_FUN1nb in html_render_deep()

The new TEX_FUN1nb introduced by r99741 was not added to the
html_render_deep() pattern matching list. This was spotted by
an ocaml compilation warning:

File "html.ml", line 74, characters 31-2966:
Warning 8: this pattern-matching is not exhaustive.
Here is an example of a value that is not matched:
TEX_FUN1nb (_, _)::_
Modified paths:
  • /trunk/extensions/Math/math/html.ml (modified) (history)

Diff [purge]

Index: trunk/extensions/Math/math/html.ml
——@@ -102,6 +102,7 @@
103103 | TEX_BOX (_,s)::r -> ("",s,"")::html_render_deep ctx r
104104 | TEX_LITERAL (TEX_ONLY _)::_ -> raise Too_difficult_for_html
105105 | TEX_FUN1 _::_ -> raise Too_difficult_for_html
 106+ | TEX_FUN1nb _::_ -> raise Too_difficult_for_html
106107 | TEX_FUN2 _::_ -> raise Too_difficult_for_html
107108 | TEX_FUN2nb _::_ -> raise Too_difficult_for_html
108109 | TEX_FUN2sq _::_ -> raise Too_difficult_for_html

Sign-offs

UserFlagDate
GWickeinspected09:44, 21 December 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r103240REL1_18 MFT r98560, r99741, r101031, r101404, r102438, r102563, r102953, r103197reedy22:08, 15 November 2011
r1032421.18wmf1 MFT r98560, r99741, r101031, r101404, r102438, r102563, r102953, r10...reedy22:10, 15 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99741The following patches restore how texvc added braces for all commands...thenub31423:04, 13 October 2011

Comments

#Comment by Hashar (talk | contribs)   17:27, 15 November 2011

tagging for 1.18,1.18wmf1 .

This fix a compilation warning introduced by r99741.

#Comment by Hashar (talk | contribs)   19:27, 15 November 2011

This is not a 1.18 tarball blocker

#Comment by GWicke (talk | contribs)   09:44, 21 December 2011

Handling a previously missing case just makes the failure for this case explicit, so there should be no behavior change. Marking as OK.

Status & tagging log