r103143 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103142‎ | r103143 | r103144 >
Date:10:49, 15 November 2011
Author:santhosh
Status:ok (Comments)
Tags:
Comment:
Fix WebFonts in Modern script.
Modified paths:
  • /trunk/extensions/WebFonts/WebFonts.php (modified) (history)
  • /trunk/extensions/WebFonts/resources/ext.webfonts.modern.css (added) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.modern.css
@@ -0,0 +1,29 @@
 2+#p-personal {
 3+ /* #p-personal has overflow:hidden. That makes a dropdown menu appearing hidden.
 4+ * overriding it this way may not be the best way.
 5+ */
 6+ overflow: visible!important;
 7+}
 8+
 9+div#webfonts-menu li {
 10+ background-color: #FFFFFF;
 11+ font-weight: normal;
 12+ white-space: nowrap;
 13+ text-transform: none;
 14+ font-variant: normal;
 15+}
 16+
 17+div#webfonts-menu ul {
 18+ border: solid 1px silver;
 19+ background-color: #FFFFFF;
 20+ height: auto;
 21+}
 22+
 23+div#webfonts-menu li a:hover{
 24+ color: #0645AD;
 25+}
 26+
 27+div#webfonts-menu li:hover {
 28+ background-color: #FFFFFF;
 29+}
 30+
Property changes on: trunk/extensions/WebFonts/resources/ext.webfonts.modern.css
___________________________________________________________________
Added: svn:eol-style
131 + native
Index: trunk/extensions/WebFonts/WebFonts.php
@@ -51,6 +51,9 @@
5252 $wgResourceModules['ext.webfonts.core'] = array(
5353 'scripts' => array( 'resources/ext.webfonts.js', 'resources/ext.webfonts.fontlist.js' ),
5454 'styles' => 'resources/ext.webfonts.css',
 55+ 'skinStyles' => array(
 56+ 'modern' => 'resources/ext.webfonts.modern.css',
 57+ ),
5558 'localBasePath' => $dir,
5659 'remoteExtPath' => 'WebFonts',
5760 'messages' => array( 'webfonts-load', 'webfonts-reset' ),

Comments

#Comment by Nikerabbit (talk | contribs)   12:13, 15 November 2011

Works ok, but the overflow makes rest of the entries show up next line above other stuff.

#Comment by Amire80 (talk | contribs)   07:24, 25 November 2011

That's a bug in the skin itself.

Status & tagging log