r103100 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103099‎ | r103100 | r103101 >
Date:01:00, 15 November 2011
Author:preilly
Status:deferred (Comments)
Tags:mobile 
Comment:
add android logo fix
Modified paths:
  • /trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/layout/_search_webkit.html.php
——@@ -22,7 +22,7 @@
2323
2424 $searchWebkitHtml = <<<EOD
2525 <div id='header'>
26 - <div id='searchbox'>
 26+ <div id='searchbox' {$logoDisplayNone}>
2727 <img width="35" height="22" alt='Logo' id='logo' src='{$wgMobileFrontendLogo}' {$logoOnClick} {$logoDisplayNone} />
2828 <form action='{$scriptUrl}' class='search_bar' method='get' {$searchBoxDisplayNone}>
2929 <input type="hidden" value="Special:Search" name="title" />

Follow-up revisions

RevisionCommit summaryAuthorDate
r1031011.18wmf1: MFT r103100preilly01:01, 15 November 2011
r103102add android logo fixpreilly01:03, 15 November 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   01:26, 13 December 2011

What does hiding a logo accomplish here? Is something wrong with the logo?

#Comment by Brion VIBBER (talk | contribs)   01:27, 13 December 2011

Is this for the mode where we hide the entire top chrome?

#Comment by Preilly (talk | contribs)   01:29, 13 December 2011

This was for hiding the search bar if the application already has one.

#Comment by Brion VIBBER (talk | contribs)   01:30, 13 December 2011

See my note on r103097; we can't actually set that header on every page view unless we're replacing every iframe page load with a custom data load; it's pretty awkward to work with.

Status & tagging log