r103096 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103095‎ | r103096 | r103097 >
Date:00:41, 15 November 2011
Author:johnduhart
Status:resolved (Comments)
Tags:
Comment:
Followup r100506 and add permissions checking that I missed using functions added in r103095
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)
  • /trunk/extensions/CheckUser/SpecialCheckUserLog.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -19,6 +19,7 @@
2020 public function execute( $subpage ) {
2121 global $wgRequest, $wgOut, $wgUser, $wgContLang;
2222
 23+ $this->checkPermissions();
2324 $this->setHeaders();
2425
2526 $user = $wgRequest->getText( 'user' ) ?
Index: trunk/extensions/CheckUser/SpecialCheckUserLog.php
@@ -6,6 +6,8 @@
77 }
88
99 function execute( $par ) {
 10+ $this->checkPermissions();
 11+
1012 $out = $this->getOutput();
1113 $request = $this->getRequest();
1214 $this->setHeaders();

Follow-up revisions

RevisionCommit summaryAuthorDate
r103106Adding 'action-' messages for checkuser and checkuser-log...johnduhart01:09, 15 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100506Moved CheckUser log stuff into a separate special pagejohnduhart17:44, 22 October 2011
r103095Added function to SpecialPage to simplify permissions checking in SpecialPage...johnduhart00:37, 15 November 2011

Comments

#Comment by Johnduhart (talk | contribs)   00:43, 15 November 2011

Right so permissions are fixed, but this introduces a new problem

You do not have permission to <action-checkuser>, for the following reason:

bleh

Status & tagging log