r103087 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103086‎ | r103087 | r103088 >
Date:00:08, 15 November 2011
Author:neilk
Status:deferred
Tags:
Comment:
reverting r103068 -- we need a few more fixes and Reedy wants to push out unrelated changes
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/UploadWizard/UploadWizard.config.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/UploadWizard/resources/mw.FormDataTransport.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/UploadWizard/UploadWizard.config.php
@@ -414,9 +414,6 @@
415415 'enableFormData' => true,
416416
417417 // should multi-file select be available in supporting browsers?
418 - 'enableMultiFileSelect' => true,
 418+ 'enableMultiFileSelect' => true
419419
420 - // should chunked uploading be enabled? false for now since the backend isn't really ready.
421 - 'enableChunked' => false,
422 -
423420 );
Index: branches/wmf/1.18wmf1/extensions/UploadWizard/resources/mw.FormDataTransport.js
@@ -31,7 +31,7 @@
3232 file = this.uploadObject.file,
3333 bytesAvailable = file.size;
3434
35 - if( mw.UploadWizard.config[ 'enableChunked' ] && file.size > this.chunkSize ) {
 35+ if(file.size > this.chunkSize) {
3636 this.uploadChunk(0);
3737 } else {
3838 this.xhr = new XMLHttpRequest();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103068MFT r103062 -- add config flag to turn off chunked APIneilk23:16, 14 November 2011

Status & tagging log