r103080 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103079‎ | r103080 | r103081 >
Date:23:44, 14 November 2011
Author:kaldari
Status:ok
Tags:
Comment:
error checking is too aggressive in this case
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects.bt.js (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects2nd-US.js (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects2nd.js (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js
@@ -166,7 +166,7 @@
167167 $( "#other-amount" ).focus( function() {
168168 $( '#input_amount_other' ).attr( 'checked', true );
169169 var otherAmount = $( 'input#other-amount' ).val();
170 - if ( otherAmount && !isNaN( otherAmount ) ) {
 170+ if ( otherAmount ) {
171171 setAmount( $( 'input#other-amount' ) );
172172 }
173173 } );
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects.bt.js
@@ -80,7 +80,7 @@
8181 $( "#other-amount" ).focus( function() {
8282 $( '#input_amount_other' ).attr( 'checked', true );
8383 var otherAmount = $( 'input#other-amount' ).val();
84 - if ( otherAmount && !isNaN( otherAmount ) ) {
 84+ if ( otherAmount ) {
8585 setAmount( $( 'input#other-amount' ) );
8686 }
8787 } );
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects2nd.js
@@ -114,7 +114,7 @@
115115 $( "#other-amount" ).focus( function() {
116116 $( '#input_amount_other' ).attr( 'checked', true );
117117 var otherAmount = $( 'input#other-amount' ).val();
118 - if ( otherAmount && !isNaN( otherAmount ) ) {
 118+ if ( otherAmount ) {
119119 setAmount( $( 'input#other-amount' ) );
120120 }
121121 } );
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects2nd-US.js
@@ -106,7 +106,7 @@
107107 $( "#other-amount" ).focus( function() {
108108 $( '#input_amount_other' ).attr( 'checked', true );
109109 var otherAmount = $( 'input#other-amount' ).val();
110 - if ( otherAmount && !isNaN( otherAmount ) ) {
 110+ if ( otherAmount ) {
111111 setAmount( $( 'input#other-amount' ) );
112112 }
113113 } );

Follow-up revisions

RevisionCommit summaryAuthorDate
r103263MFT r103080, r103130, r103219, r103223, r103229, r103235, r103237, r103238, r...awjrichards23:43, 15 November 2011

Status & tagging log