r103070 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103069‎ | r103070 | r103071 >
Date:23:23, 14 November 2011
Author:pgehres
Status:ok (Comments)
Tags:
Comment:
Fixes to dd-BE
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects2nd.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php
@@ -65,7 +65,10 @@
6666 // GlobalCollect
6767 $wgResourceModules[ 'gc.form.rapidhtml.webitects' ] = array(
6868 'styles' => '',
69 - 'scripts' => 'js/webitects.js',
 69+ 'scripts' => array(
 70+ 'js/webitects.js',
 71+ 'js/webitects.accordian.js',
 72+ ),
7073 'dependencies' => 'di.form.rapidhtml.webitects',
7174 'localBasePath' => dirname( __FILE__ ).'/../../globalcollect_gateway/forms',
7275 'remoteExtPath' => $wgGlobalCollectRapidHtmlRemoteExtPath,
@@ -109,8 +112,11 @@
110113 );
111114 $wgResourceModules[ 'gc.form.rapidhtml.webitects.bt' ] = array(
112115 'styles' => '',
113 - 'scripts' => 'js/webitects.bt.js',
114 - 'dependencies' => 'gc.form.rapidhtml.webitects.2nd',
 116+// 'scripts' => 'js/webitects.bt.js',
 117+ 'dependencies' => array(
 118+ 'gc.form.rapidhtml.webitects.2nd',
 119+ 'gc.form.core.validate'
 120+ ),
115121 'localBasePath' => dirname( __FILE__ ).'/../../globalcollect_gateway/forms',
116122 'remoteExtPath' => $wgGlobalCollectRapidHtmlRemoteExtPath,
117123 );
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects2nd.js
@@ -48,6 +48,14 @@
4949 displayCreditCardForm()
5050 }
5151 } );
 52+
 53+ $( "#bt-continueBtn" ).live( "click", function() {
 54+ if ( validateAmount() && validate_personal( document.paypalcontribution ) ) {
 55+ document.paypalcontribution.action = actionURL;
 56+ document.paypalcontribution.submit();
 57+ }
 58+ } );
 59+
5260 // Set the cards to progress to step 3
5361 $( ".cardradio" ).live( "click", function() {
5462 if ( validate_personal( document.paypalcontribution ) && validateAmount() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r103105commenting out broken stuff for now, follow-up to r103070kaldari01:05, 15 November 2011
r103841MFT r102185, r103070, r103105, r103281, r103500, r103515, r103636khorn21:57, 21 November 2011

Comments

#Comment by Kaldari (talk | contribs)   00:27, 15 November 2011

1st problem: gc.form.core.validate currently only works with TwoStepAmount.php (it's something jeremy build for that form). You're probably wanting di.form.core.validate, is what all other forms use.

2nd problem: js/webitects.accordian.js doesn't exist.

#Comment by Pgehres (WMF) (talk | contribs)   22:04, 15 November 2011

You resolved in r103105.

Status & tagging log