r103048 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103047‎ | r103048 | r103049 >
Date:22:07, 14 November 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
followup r102365: bugfix (free text dropped when editing pages)
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
——@@ -950,7 +950,7 @@
951951 } else {
952952 $sfgTabIndex++;
953953 $sfgFieldNum++;
954 - if ( $cur_value === '' ) {
 954+ if ( is_null( $cur_value ) ) {
955955 $default_value = '!free_text!';
956956 } else {
957957 $default_value = $cur_value;

Follow-up revisions

RevisionCommit summaryAuthorDate
r103855Follow-up to r103048 - both a blank and a null check are apparently needed hereyaron22:51, 21 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102365strict comparators for empty stringsjeroendedauw02:25, 8 November 2011