r102970 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102969‎ | r102970 | r102971 >
Date:12:02, 14 November 2011
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
(bug 20050) References containing numbered lists cause Tidy to corrupt the references list. Patch by Brad Jorsch
Modified paths:
  • /trunk/extensions/Cite/Cite_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/Cite_body.php
@@ -693,13 +693,13 @@
694694 'cite_references_link_one',
695695 $this->referencesKey( $key ),
696696 $this->refKey( $key ),
697 - $val
 697+ rtrim( $val, "\n" ) . "\n"
698698 );
699699 } elseif ( isset( $val['follow'] ) ) {
700700 return wfMsgForContentNoTrans(
701701 'cite_references_no_link',
702702 $this->referencesKey( $val['follow'] ),
703 - $val['text']
 703+ rtrim( $val['text'], "\n" ) . "\n"
704704 );
705705 } elseif ( $val['text'] == '' ) {
706706 return wfMsgForContentNoTrans(
@@ -717,7 +717,7 @@
718718 # $this->refKey( $val['key'], $val['count'] ),
719719 $this->refKey( $val['key'] ),
720720
721 - ( $val['text'] != '' ? $val['text'] : $this->error( 'cite_error_references_no_text', $key ) )
 721+ ( $val['text'] != '' ? rtrim( $val['text'], "\n" ) . "\n" : $this->error( 'cite_error_references_no_text', $key ) )
722722 );
723723 // Standalone named reference, I want to format this like an
724724 // anonymous reference because displaying "1. 1.1 Ref text" is
@@ -729,7 +729,7 @@
730730 $this->referencesKey( $key . "-" . $val['key'] ),
731731 # $this->refKey( $key, $val['count'] ),
732732 $this->refKey( $key, $val['key'] . "-" . $val['count'] ),
733 - ( $val['text'] != '' ? $val['text'] : $this->error( 'cite_error_references_no_text', $key ) )
 733+ ( $val['text'] != '' ? rtrim( $val['text'], "\n" ) . "\n" : $this->error( 'cite_error_references_no_text', $key ) )
734734 );
735735 // Named references with >1 occurrences
736736 } else {
@@ -749,7 +749,7 @@
750750 return wfMsgForContentNoTrans( 'cite_references_link_many',
751751 $this->referencesKey( $key . "-" . $val['key'] ),
752752 $list,
753 - ( $val['text'] != '' ? $val['text'] : $this->error( 'cite_error_references_no_text', $key ) )
 753+ ( $val['text'] != '' ? rtrim( $val['text'], "\n" ) . "\n" : $this->error( 'cite_error_references_no_text', $key ) )
754754 );
755755 }
756756 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r102971Followup r102970, fix parser testscatrope12:20, 14 November 2011

Comments

#Comment by Reedy (talk | contribs)   12:10, 14 November 2011
     [exec] There were 15 failures:
     [exec] 
     [exec] 1) CiteParserTests::testParserTest with data set #1 ('Simple <ref>, with <references/>', 'Wikipedia rocks!<ref>Proceeds of Rockology, vol. XXI</ref>
     [exec] 
     [exec] <references/>', '<p>Wikipedia rocks!<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
     [exec] ', '', '')
     [exec] Simple <ref>, with <references/>
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p>Wikipedia rocks!<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 2) CiteParserTests::testParserTest with data set #2 ('<ref> with a simple template', 'Templating<ref>{{simple template}}</ref>
     [exec] 
     [exec] <references/>', '<p>Templating<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> A <i>simple</i> template.</li></ol>
     [exec] ', '', '')
     [exec] <ref> with a simple template
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p>Templating<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> A <i>simple</i> template.</li></ol>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> A <i>simple</i> template.
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 3) CiteParserTests::testParserTest with data set #3 ('<ref> with a ', 'Templating<ref><nowiki>{{simple template}}</ref>
     [exec] 
     [exec] <references/>', '<p>Templating<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> {{simple template}}</li></ol>
     [exec] ', '', '')
     [exec] <ref> with a <nowiki>
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p>Templating<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> {{simple template}}</li></ol>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> {{simple template}}
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 4) CiteParserTests::testParserTest with data set #6 ('<!--comment--> in a <ref> ([https://bugzilla.wikimedia.org/show_bug.cgi?id=5384 bug 5384])', 'Templating<ref>Text<!--comment--></ref>
     [exec] 
     [exec] <references/>', '<p>Templating<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Text</li></ol>
     [exec] ', '', '')
     [exec] <!--comment--> in a <ref> ([https://bugzilla.wikimedia.org/show_bug.cgi?id=5384 bug 5384])
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p>Templating<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Text</li></ol>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Text
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 5) CiteParserTests::testParserTest with data set #7 ('<references> after <gallery> ([https://bugzilla.wikimedia.org/show_bug.cgi?id=6164 bug 6164])', '<ref>one</ref>
     [exec] 
     [exec] <gallery>Image:Foobar.jpg</gallery>
     [exec] 
     [exec] <references/>', '<p><sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec] </p>
     [exec] <ul class="gallery">
     [exec] 		<li class="gallerybox" style="width: 155px"><div style="width: 155px">
     [exec] 			<div class="thumb" style="width: 150px;"><div style="margin:68px auto;"><a href="https://www.mediawiki.org/wiki/File:Foobar.jpg" class="image"><img alt="Foobar.jpg" src="[http://example.com/images/3/3a/Foobar.jpg http://example.com/images/3/3a/Foobar.jpg]" width="120" height="14" /></a></div></div>
     [exec] 			<div class="gallerytext">
     [exec] 			</div>
     [exec] 		</div></li>
     [exec] </ul>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> one</li></ol>
     [exec] ', '', '')
     [exec] <references> after <gallery> ([https://bugzilla.wikimedia.org/show_bug.cgi?id=6164 bug 6164])
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  </ul>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> one</li></ol>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> one
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 6) CiteParserTests::testParserTest with data set #10 ('Blank ref followed by ref with content', '<ref name="blank"/>
     [exec] 
     [exec] <ref name="blank">content</ref>
     [exec] 
     [exec] <references/>', '<p><sup id="cite_ref-blank_0-0" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec] </p><p><sup id="cite_ref-blank_0-1" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> content</li></ol>
     [exec] ', '', '')
     [exec] Blank ref followed by ref with content
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p><sup id="cite_ref-blank_0-0" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec]  </p><p><sup id="cite_ref-blank_0-1" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> content</li></ol>
     [exec] +<ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> content
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 7) CiteParserTests::testParserTest with data set #11 ('Regression: non-blank ref "0" followed by ref with content', '<ref name="blank">0</ref>
     [exec] 
     [exec] <ref name="blank">content</ref>
     [exec] 
     [exec] <references/>', '<p><sup id="cite_ref-blank_0-0" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec] </p><p><sup id="cite_ref-blank_0-1" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> 0</li></ol>
     [exec] ', '', '')
     [exec] Regression: non-blank ref "0" followed by ref with content
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p><sup id="cite_ref-blank_0-0" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec]  </p><p><sup id="cite_ref-blank_0-1" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> 0</li></ol>
     [exec] +<ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> 0
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 8) CiteParserTests::testParserTest with data set #12 ('Regression sanity check: non-blank ref "1" followed by ref with content', '<ref name="blank">1</ref>
     [exec] 
     [exec] <ref name="blank">content</ref>
     [exec] 
     [exec] <references/>', '<p><sup id="cite_ref-blank_0-0" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec] </p><p><sup id="cite_ref-blank_0-1" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> 1</li></ol>
     [exec] ', '', '')
     [exec] Regression sanity check: non-blank ref "1" followed by ref with content
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p><sup id="cite_ref-blank_0-0" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec]  </p><p><sup id="cite_ref-blank_0-1" class="reference"><a href="#cite_note-blank-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> 1</li></ol>
     [exec] +<ol class="references"><li id="cite_note-blank-0">↑ <sup><a href="#cite_ref-blank_0-0">1.0</a></sup> <sup><a href="#cite_ref-blank_0-1">1.1</a></sup> 1
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 9) CiteParserTests::testParserTest with data set #13 ('Ref names containing a number', '<ref name="test123test">One</ref>
     [exec] <ref name="123test">Two</ref>
     [exec] <ref name="test123">Three</ref>
     [exec] 
     [exec] <references />', '<p><sup id="cite_ref-test123test_0-0" class="reference"><a href="#cite_note-test123test-0">[1]</a></sup>
     [exec] <sup id="cite_ref-123test_1-0" class="reference"><a href="#cite_note-123test-1">[2]</a></sup>
     [exec] <sup id="cite_ref-test123_2-0" class="reference"><a href="#cite_note-test123-2">[3]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-test123test-0"><a href="#cite_ref-test123test_0-0">↑</a> One</li>
     [exec] <li id="cite_note-123test-1"><a href="#cite_ref-123test_1-0">↑</a> Two</li>
     [exec] <li id="cite_note-test123-2"><a href="#cite_ref-test123_2-0">↑</a> Three</li></ol>
     [exec] ', '', '')
     [exec] Ref names containing a number
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p><sup id="cite_ref-test123test_0-0" class="reference"><a href="#cite_note-test123test-0">[1]</a></sup>
     [exec]  <sup id="cite_ref-123test_1-0" class="reference"><a href="#cite_note-123test-1">[2]</a></sup>
     [exec]  <sup id="cite_ref-test123_2-0" class="reference"><a href="#cite_note-test123-2">[3]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-test123test-0"><a href="#cite_ref-test123test_0-0">↑</a> One</li>
     [exec] -<li id="cite_note-123test-1"><a href="#cite_ref-123test_1-0">↑</a> Two</li>
     [exec] -<li id="cite_note-test123-2"><a href="#cite_ref-test123_2-0">↑</a> Three</li></ol>
     [exec] +<ol class="references"><li id="cite_note-test123test-0"><a href="#cite_ref-test123test_0-0">↑</a> One
     [exec] +</li>
     [exec] +<li id="cite_note-123test-1"><a href="#cite_ref-123test_1-0">↑</a> Two
     [exec] +</li>
     [exec] +<li id="cite_note-test123-2"><a href="#cite_ref-test123_2-0">↑</a> Three
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 10) CiteParserTests::testParserTest with data set #14 ('Erroneous refs', '<ref name="0">Zero</ref>
     [exec] 
     [exec] <ref>Also zero, but differently! (Normal ref)</ref>
     [exec] 
     [exec] <ref />
     [exec] 
     [exec] <ref name="foo" name="bar" />
     [exec] 
     [exec] <ref name="blankwithnoreference" />
     [exec] 
     [exec] <references name="quasit" />
     [exec] 
     [exec] <references />', '<p><strong class="error">Cite error: Invalid <code><ref></code> tag;
     [exec] name cannot be a simple integer. Use a descriptive title</strong>
     [exec] </p><p><sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec] </p><p><strong class="error">Cite error: Invalid <code><ref></code> tag;
     [exec] refs with no content must have a name</strong>
     [exec] </p><p><sup id="cite_ref-bar_1-0" class="reference"><a href="#cite_note-bar-1">[2]</a></sup>
     [exec] </p><p><sup id="cite_ref-blankwithnoreference_2-0" class="reference"><a href="#cite_note-blankwithnoreference-2">[3]</a></sup>
     [exec] </p><p><strong class="error">Cite error: Invalid <code><references></code> tag;
     [exec] parameter "group" is allowed only.
     [exec] Use <code><references /></code>, or <code><references group="..." /></code></strong>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Also zero, but differently! (Normal ref)</li>
     [exec] <li id="cite_note-bar"><a href="#cite_ref-bar_0">↑</a> <strong class="error">Cite error: Invalid <code><ref></code> tag;
     [exec] no text was provided for refs named <code>bar</code></strong></li>
     [exec] <li id="cite_note-blankwithnoreference"><a href="#cite_ref-blankwithnoreference_0">↑</a> <strong class="error">Cite error: Invalid <code><ref></code> tag;
     [exec] no text was provided for refs named <code>blankwithnoreference</code></strong></li></ol>
     [exec] ', '', '')
     [exec] Erroneous refs
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Also zero, but differently! (Normal ref)</li>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Also zero, but differently! (Normal ref)
     [exec] +</li>
     [exec]  <li id="cite_note-bar"><a href="#cite_ref-bar_0">↑</a> <strong class="error">Cite error: Invalid <code><ref></code> tag;
     [exec]  no text was provided for refs named <code>bar</code></strong></li>
     [exec]  <li id="cite_note-blankwithnoreference"><a href="#cite_ref-blankwithnoreference_0">↑</a> <strong class="error">Cite error: Invalid <code><ref></code> tag;
     [exec]  no text was provided for refs named <code>blankwithnoreference</code></strong></li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 11) CiteParserTests::testParserTest with data set #15 ('Simple <ref>, with <references/> in group', 'Wikipedia rocks!<ref>Proceeds of Rockology, vol. XXI</ref>
     [exec] Wikipedia rocks!<ref group=note>Proceeds of Rockology, vol. XXI</ref>
     [exec] 
     [exec] <references/>
     [exec] <references group=note/>', '<p>Wikipedia rocks!<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec] Wikipedia rocks!<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[note 1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
     [exec] <ol class="references"><li id="cite_note-1"><a href="#cite_ref-1">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
     [exec] ', '', '')
     [exec] Simple <ref>, with <references/> in group
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p>Wikipedia rocks!<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[1]</a></sup>
     [exec]  Wikipedia rocks!<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[note 1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
     [exec] -<ol class="references"><li id="cite_note-1"><a href="#cite_ref-1">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI
     [exec] +</li></ol>
     [exec] +<ol class="references"><li id="cite_note-1"><a href="#cite_ref-1">↑</a> Proceeds of Rockology, vol. XXI
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 12) CiteParserTests::testParserTest with data set #16 ('Simple <ref>, with <references/> in group, with groupname in chinese ', 'AAA<ref group="参">ref a</ref>BBB<ref group="注">note b</ref>CCC<ref group="参">ref c</ref>
     [exec] 
     [exec] ;refs
     [exec] <references group="参" />
     [exec] ;notes
     [exec] <references group="注" />', '<p>AAA<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[参 1]</a></sup>BBB<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[注 1]</a></sup>CCC<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">[参 2]</a></sup>
     [exec] </p>
     [exec] <dl><dt>refs
     [exec] </dt></dl>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> ref a</li>
     [exec] <li id="cite_note-2"><a href="#cite_ref-2">↑</a> ref c</li></ol>
     [exec] <dl><dt>notes
     [exec] </dt></dl>
     [exec] <ol class="references"><li id="cite_note-1"><a href="#cite_ref-1">↑</a> note b</li></ol>
     [exec] ', '', '')
     [exec] Simple <ref>, with <references/> in group, with groupname in chinese 
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p>AAA<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[参 1]</a></sup>BBB<sup id="cite_ref-1" class="reference"><a href="#cite_note-1">[注 1]</a></sup>CCC<sup id="cite_ref-2" class="reference"><a href="#cite_note-2">[参 2]</a></sup>
     [exec]  </p>
     [exec]  <dl><dt>refs
     [exec]  </dt></dl>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> ref a</li>
     [exec] -<li id="cite_note-2"><a href="#cite_ref-2">↑</a> ref c</li></ol>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> ref a
     [exec] +</li>
     [exec] +<li id="cite_note-2"><a href="#cite_ref-2">↑</a> ref c
     [exec] +</li></ol>
     [exec]  <dl><dt>notes
     [exec]  </dt></dl>
     [exec] -<ol class="references"><li id="cite_note-1"><a href="#cite_ref-1">↑</a> note b</li></ol>
     [exec] +<ol class="references"><li id="cite_note-1"><a href="#cite_ref-1">↑</a> note b
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 13) CiteParserTests::testParserTest with data set #17 ('<ref> defined in <references>', '<ref name="foo"/>
     [exec] 
     [exec] <references>
     [exec] <ref name="foo">BAR</ref>
     [exec] </references>', '<p><sup id="cite_ref-foo_0-0" class="reference"><a href="#cite_note-foo-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-foo-0"><a href="#cite_ref-foo_0-0">↑</a> BAR</li></ol>
     [exec] ', '', '')
     [exec] <ref> defined in <references>
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p><sup id="cite_ref-foo_0-0" class="reference"><a href="#cite_note-foo-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-foo-0"><a href="#cite_ref-foo_0-0">↑</a> BAR</li></ol>
     [exec] +<ol class="references"><li id="cite_note-foo-0"><a href="#cite_ref-foo_0-0">↑</a> BAR
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 14) CiteParserTests::testParserTest with data set #18 ('<ref> defined in <references> called with #tag', '<ref name="foo"/>
     [exec] 
     [exec] {{#tag:references|
     [exec] <ref name="foo">BAR</ref>
     [exec] }}', '<p><sup id="cite_ref-foo_0-0" class="reference"><a href="#cite_note-foo-0">[1]</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-foo-0"><a href="#cite_ref-foo_0-0">↑</a> BAR</li></ol>
     [exec] ', '', '')
     [exec] <ref> defined in <references> called with #tag
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p><sup id="cite_ref-foo_0-0" class="reference"><a href="#cite_note-foo-0">[1]</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-foo-0"><a href="#cite_ref-foo_0-0">↑</a> BAR</li></ol>
     [exec] +<ol class="references"><li id="cite_note-foo-0"><a href="#cite_ref-foo_0-0">↑</a> BAR
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] 15) CiteParserTests::testParserTest with data set #20 ('<ref> with custom group link', 'Wikipedia rocks!<ref group="klingon">Proceeds of Rockology, vol. XXI</ref>
     [exec] 
     [exec] <references group="klingon"/>', '<p>Wikipedia rocks!<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[wa\']</a></sup>
     [exec] </p>
     [exec] <ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
     [exec] ', '', '')
     [exec] <ref> with custom group link
     [exec] Failed asserting that two strings are equal.
     [exec] --- Expected
     [exec] +++ Actual
     [exec] @@ @@
     [exec]  <p>Wikipedia rocks!<sup id="cite_ref-0" class="reference"><a href="#cite_note-0">[wa']</a></sup>
     [exec]  </p>
     [exec] -<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI</li></ol>
     [exec] +<ol class="references"><li id="cite_note-0"><a href="#cite_ref-0">↑</a> Proceeds of Rockology, vol. XXI
     [exec] +</li></ol>
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:539
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] --
     [exec] 
     [exec] 
     [exec] There was 1 incomplete test:
     [exec] 
     [exec] 1) ApiTest::testApiListPages
     [exec] Somebody needs to finish loving me
     [exec] 
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/includes/api/ApiTest.php:214
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:64
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:44
     [exec] /var/lib/jenkins/jobs/MediaWiki-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
     [exec] 
     [exec] �[37;41m�[2KFAILURES!
     [exec] �[0m�[37;41m�[2KTests: 2398, Assertions: 33261, Failures: 15, Incomplete: 1.
     [exec] �[0m�[2K
#Comment by Catrope (talk | contribs)   14:00, 14 November 2011

Fixed in followup

Status & tagging log