r102945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102944‎ | r102945 | r102946 >
Date:08:06, 14 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 32380) Make get powered by link target protocol-relative
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -782,7 +782,7 @@
783783 global $wgStylePath;
784784
785785 $url = htmlspecialchars( "$wgStylePath/common/images/poweredby_mediawiki_88x31.png" );
786 - $text = '<a href="http://www.mediawiki.org/"><img src="' . $url . '" height="31" width="88" alt="Powered by MediaWiki" /></a>';
 786+ $text = '<a href="https://www.mediawiki.org//www.mediawiki.org/"><img src="' . $url . '" height="31" width="88" alt="Powered by MediaWiki" /></a>';
787787 wfRunHooks( 'SkinGetPoweredBy', array( &$text, $this ) );
788788 return $text;
789789 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r102983Followup r102945: $wgFooterIcons toocatrope14:08, 14 November 2011

Comments

#Comment by Dantman (talk | contribs)   08:16, 14 November 2011

$wgFooterIcons in DefaultSettings.php needs to be updated too.

Status & tagging log