r102900 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102899‎ | r102900 | r102901 >
Date:17:06, 13 November 2011
Author:robin
Status:ok
Tags:
Comment:
The first parameter should be the level... $categoryLevel wasn't used, and $categoryMain was used twice. Strange.
Modified paths:
  • /trunk/extensions/Babel/Babel.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Babel/Babel.class.php
@@ -254,18 +254,18 @@
255255
256256 $text = wfMsgExt( "babel-$level-n",
257257 array( 'language' => $language, 'parsemag' ),
258 - $categoryMain, $categoryMain, '', self::$title->getDBkey()
 258+ $categoryLevel, $categoryMain, '', self::$title->getDBkey()
259259 );
260260
261261 $fallback = wfMsgExt( "babel-$level-n",
262262 array( 'language' => Language::getFallbackfor( $language ), 'parsemag' ),
263 - $categoryMain, $categoryMain, '', self::$title->getDBkey()
 263+ $categoryLevel, $categoryMain, '', self::$title->getDBkey()
264264 );
265265
266266 if ( $text == $fallback ) {
267267 $text = wfMsgExt( "babel-$level",
268268 array( 'language' => $language, 'parsemag' ),
269 - $categoryMain, $categoryMain, $name, self::$title->getDBkey()
 269+ $categoryLevel, $categoryMain, $name, self::$title->getDBkey()
270270 );
271271 }
272272

Follow-up revisions

RevisionCommit summaryAuthorDate
r105909Babel: MFT r102899 r102900 r102912 r105540nikerabbit17:38, 12 December 2011

Status & tagging log