r102870 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102869‎ | r102870 | r102871 >
Date:19:53, 12 November 2011
Author:btongminh
Status:ok
Tags:
Comment:
Follow-up r102867, another validation fix
Modified paths:
  • /trunk/extensions/VipsScaler/SpecialVipsTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/VipsScaler/SpecialVipsTest.php
@@ -195,7 +195,8 @@
196196 return true;
197197 }
198198 public static function validateWidth( $input, $allData ) {
199 - if ( self::validateFileInput( $allData['File'], $allData ) !== true ) {
 199+ if ( self::validateFileInput( $allData['File'], $allData ) !== true
 200+ || !trim( $allData['File'] ) ) {
200201 # Invalid file, error will already be shown at file field
201202 return true;
202203 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102867Add more validation of input, fix sharpening validationbtongminh18:39, 12 November 2011

Status & tagging log