r102869 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102868‎ | r102869 | r102870 >
Date:18:45, 12 November 2011
Author:btongminh
Status:ok
Tags:
Comment:
Follow-up r102867, don't try to generate thumbnails if validation failed
Modified paths:
  • /trunk/extensions/VipsScaler/SpecialVipsTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/VipsScaler/SpecialVipsTest.php
@@ -44,9 +44,6 @@
4545
4646 if ( $request->getText( 'thumb' ) ) {
4747 $this->streamThumbnail();
48 - } elseif ( $par || $request->getText( 'file' ) ) {
49 - $this->showForm();
50 - $this->showThumbnails();
5148 } else {
5249 $this->showForm();
5350 }
@@ -134,6 +131,7 @@
135132 $result = $form->show();
136133 if( $result === true or $result instanceof Status && $result->isGood() ) {
137134 $form->displayForm( $result );
 135+ $this->showThumbnails();
138136 }
139137 }
140138

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102867Add more validation of input, fix sharpening validationbtongminh18:39, 12 November 2011

Status & tagging log