r102848 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102847‎ | r102848 | r102849 >
Date:09:08, 12 November 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 32374) Heading dropdown disappears behind textarea after closing and re-opening the Advanced section. This seems to be caused by the collapsing animation that sets position:absolute on the section, does the fadeOut animation, then after the animation sets the position 'back' to relative. However, the position was never relative to begin with, so now the absolutely positioned header dropdown has a different closest positioned anchestor and it appears things go wrong from there and cause the bug. So instead of setting the position to relative after the animation, set it back to what it actually was before, which is static (implicitly).
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.js
——@@ -602,7 +602,7 @@
603603 var $previousSections = $section.parent().find( '.section-visible' );
604604 $previousSections.css( 'position', 'absolute' );
605605 $previousSections.removeClass( 'section-visible' );
606 - $previousSections.fadeOut( 'fast', function() { $(this).css( 'position', 'relative' ); } );
 606+ $previousSections.fadeOut( 'fast', function() { $(this).css( 'position', 'static' ); } );
607607 $(this).parent().parent().find( 'a' ).removeClass( 'current' );
608608 $sections.css( 'overflow', 'hidden' );
609609 var animate = function( $that ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r102996REL1_18 MFT r102848reedy17:59, 14 November 2011

Status & tagging log