r102795 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102794‎ | r102795 | r102796 >
Date:16:09, 11 November 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Don't pass the count parameter in rawParams() otherwise {{PLURAL:}} won't work (spotted while looking at r102794 but not related to that rev)
Modified paths:
  • /trunk/phase3/includes/ImagePage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImagePage.php
@@ -332,8 +332,8 @@
333333 rawParams( $this->makeSizeLink( $params, $width, $height ) )->
334334 parse() . ' ' .
335335 Html::rawElement( 'span', array( 'class' => 'mw-filepage-other-resolutions' ),
336 - wfMessage( 'show-big-image-other' )->
337 - rawParams( $wgLang->pipeList( $otherSizes ), count( $otherSizes ) )->parse()
 336+ wfMessage( 'show-big-image-other' )->rawParams( $wgLang->pipeList( $otherSizes ) )->
 337+ params( count( $otherSizes ) )->parse()
338338 );
339339 } elseif ( $width == 0 && $height == 0 ){
340340 # Some sort of audio file that doesn't have dimensions

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102794(bug 32358) Do not display "No higher resolution available" if the file doesn...bawolff15:59, 11 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   16:53, 11 November 2011

Good, numParams() would be even better.

Status & tagging log