r102705 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r102704‎ \| r102705 \| r102706 >
Date:	22:29, 10 November 2011
Author:	kaldari
Status:	resolved (Comments)
Tags:
Comment:	implementing support for country names and currency names, all that is lacking is building out the CountryNames and CountryNames classes for retrieving the data
Modified paths:	/trunk/extensions/cldr/CldrNamesAf.php (modified) (history) /trunk/extensions/cldr/CldrNamesAk.php (modified) (history) /trunk/extensions/cldr/CldrNamesAm.php (modified) (history) /trunk/extensions/cldr/CldrNamesAr.php (modified) (history) /trunk/extensions/cldr/CldrNamesAs.php (modified) (history) /trunk/extensions/cldr/CldrNamesAz.php (modified) (history) /trunk/extensions/cldr/CldrNamesBe.php (modified) (history) /trunk/extensions/cldr/CldrNamesBg.php (modified) (history) /trunk/extensions/cldr/CldrNamesBm.php (modified) (history) /trunk/extensions/cldr/CldrNamesBn.php (modified) (history) /trunk/extensions/cldr/CldrNamesBo.php (modified) (history) /trunk/extensions/cldr/CldrNamesBr.php (modified) (history) /trunk/extensions/cldr/CldrNamesBs.php (modified) (history) /trunk/extensions/cldr/CldrNamesCa.php (modified) (history) /trunk/extensions/cldr/CldrNamesChr.php (modified) (history) /trunk/extensions/cldr/CldrNamesCs.php (modified) (history) /trunk/extensions/cldr/CldrNamesCy.php (modified) (history) /trunk/extensions/cldr/CldrNamesDa.php (modified) (history) /trunk/extensions/cldr/CldrNamesDe.php (modified) (history) /trunk/extensions/cldr/CldrNamesDe_ch.php (modified) (history) /trunk/extensions/cldr/CldrNamesDz.php (added) (history) /trunk/extensions/cldr/CldrNamesEe.php (modified) (history) /trunk/extensions/cldr/CldrNamesEl.php (modified) (history) /trunk/extensions/cldr/CldrNamesEn.php (modified) (history) /trunk/extensions/cldr/CldrNamesEo.php (modified) (history) /trunk/extensions/cldr/CldrNamesEs.php (modified) (history) /trunk/extensions/cldr/CldrNamesEt.php (modified) (history) /trunk/extensions/cldr/CldrNamesEu.php (modified) (history) /trunk/extensions/cldr/CldrNamesFa.php (modified) (history) /trunk/extensions/cldr/CldrNamesFf.php (modified) (history) /trunk/extensions/cldr/CldrNamesFi.php (modified) (history) /trunk/extensions/cldr/CldrNamesFo.php (modified) (history) /trunk/extensions/cldr/CldrNamesFr.php (modified) (history) /trunk/extensions/cldr/CldrNamesFur.php (added) (history) /trunk/extensions/cldr/CldrNamesGa.php (modified) (history) /trunk/extensions/cldr/CldrNamesGl.php (modified) (history) /trunk/extensions/cldr/CldrNamesGsw.php (modified) (history) /trunk/extensions/cldr/CldrNamesGu.php (modified) (history) /trunk/extensions/cldr/CldrNamesGv.php (modified) (history) /trunk/extensions/cldr/CldrNamesHa.php (modified) (history) /trunk/extensions/cldr/CldrNamesHaw.php (modified) (history) /trunk/extensions/cldr/CldrNamesHe.php (modified) (history) /trunk/extensions/cldr/CldrNamesHi.php (modified) (history) /trunk/extensions/cldr/CldrNamesHr.php (modified) (history) /trunk/extensions/cldr/CldrNamesHu.php (modified) (history) /trunk/extensions/cldr/CldrNamesHy.php (modified) (history) /trunk/extensions/cldr/CldrNamesIa.php (added) (history) /trunk/extensions/cldr/CldrNamesId.php (modified) (history) /trunk/extensions/cldr/CldrNamesIg.php (modified) (history) /trunk/extensions/cldr/CldrNamesIi.php (modified) (history) /trunk/extensions/cldr/CldrNamesIs.php (modified) (history) /trunk/extensions/cldr/CldrNamesIt.php (modified) (history) /trunk/extensions/cldr/CldrNamesJa.php (modified) (history) /trunk/extensions/cldr/CldrNamesKa.php (modified) (history) /trunk/extensions/cldr/CldrNamesKab.php (modified) (history) /trunk/extensions/cldr/CldrNamesKi.php (modified) (history) /trunk/extensions/cldr/CldrNamesKk_cyrl.php (modified) (history) /trunk/extensions/cldr/CldrNamesKl.php (modified) (history) /trunk/extensions/cldr/CldrNamesKm.php (modified) (history) /trunk/extensions/cldr/CldrNamesKn.php (modified) (history) /trunk/extensions/cldr/CldrNamesKo.php (modified) (history) /trunk/extensions/cldr/CldrNamesKsh.php (added) (history) /trunk/extensions/cldr/CldrNamesKu_arab.php (added) (history) /trunk/extensions/cldr/CldrNamesKw.php (modified) (history) /trunk/extensions/cldr/CldrNamesKy.php (modified) (history) /trunk/extensions/cldr/CldrNamesLg.php (modified) (history) /trunk/extensions/cldr/CldrNamesLn.php (modified) (history) /trunk/extensions/cldr/CldrNamesLo.php (added) (history) /trunk/extensions/cldr/CldrNamesLt.php (modified) (history) /trunk/extensions/cldr/CldrNamesLv.php (modified) (history) /trunk/extensions/cldr/CldrNamesMg.php (modified) (history) /trunk/extensions/cldr/CldrNamesMk.php (modified) (history) /trunk/extensions/cldr/CldrNamesMl.php (modified) (history) /trunk/extensions/cldr/CldrNamesMn.php (modified) (history) /trunk/extensions/cldr/CldrNamesMr.php (modified) (history) /trunk/extensions/cldr/CldrNamesMs.php (modified) (history) /trunk/extensions/cldr/CldrNamesMt.php (modified) (history) /trunk/extensions/cldr/CldrNamesMy.php (modified) (history) /trunk/extensions/cldr/CldrNamesNb.php (modified) (history) /trunk/extensions/cldr/CldrNamesNe.php (modified) (history) /trunk/extensions/cldr/CldrNamesNl.php (modified) (history) /trunk/extensions/cldr/CldrNamesNn.php (modified) (history) /trunk/extensions/cldr/CldrNamesOc.php (added) (history) /trunk/extensions/cldr/CldrNamesOm.php (modified) (history) /trunk/extensions/cldr/CldrNamesOr.php (modified) (history) /trunk/extensions/cldr/CldrNamesPa.php (modified) (history) /trunk/extensions/cldr/CldrNamesPl.php (modified) (history) /trunk/extensions/cldr/CldrNamesPs.php (modified) (history) /trunk/extensions/cldr/CldrNamesPt.php (modified) (history) /trunk/extensions/cldr/CldrNamesPt_br.php (modified) (history) /trunk/extensions/cldr/CldrNamesRm.php (added) (history) /trunk/extensions/cldr/CldrNamesRn.php (modified) (history) /trunk/extensions/cldr/CldrNamesRo.php (modified) (history) /trunk/extensions/cldr/CldrNamesRu.php (modified) (history) /trunk/extensions/cldr/CldrNamesRw.php (modified) (history) /trunk/extensions/cldr/CldrNamesSah.php (modified) (history) /trunk/extensions/cldr/CldrNamesSe.php (added) (history) /trunk/extensions/cldr/CldrNamesSg.php (modified) (history) /trunk/extensions/cldr/CldrNamesShi.php (modified) (history) /trunk/extensions/cldr/CldrNamesShi_tfng.php (modified) (history) /trunk/extensions/cldr/CldrNamesSi.php (modified) (history) /trunk/extensions/cldr/CldrNamesSk.php (modified) (history) /trunk/extensions/cldr/CldrNamesSl.php (modified) (history) /trunk/extensions/cldr/CldrNamesSn.php (modified) (history) /trunk/extensions/cldr/CldrNamesSo.php (modified) (history) /trunk/extensions/cldr/CldrNamesSq.php (modified) (history) /trunk/extensions/cldr/CldrNamesSr_ec.php (modified) (history) /trunk/extensions/cldr/CldrNamesSv.php (modified) (history) /trunk/extensions/cldr/CldrNamesSw.php (modified) (history) /trunk/extensions/cldr/CldrNamesTa.php (modified) (history) /trunk/extensions/cldr/CldrNamesTe.php (modified) (history) /trunk/extensions/cldr/CldrNamesTg_cyrl.php (modified) (history) /trunk/extensions/cldr/CldrNamesTh.php (modified) (history) /trunk/extensions/cldr/CldrNamesTi.php (modified) (history) /trunk/extensions/cldr/CldrNamesTo.php (modified) (history) /trunk/extensions/cldr/CldrNamesTr.php (modified) (history) /trunk/extensions/cldr/CldrNamesUk.php (modified) (history) /trunk/extensions/cldr/CldrNamesUr.php (modified) (history) /trunk/extensions/cldr/CldrNamesUz.php (modified) (history) /trunk/extensions/cldr/CldrNamesVi.php (modified) (history) /trunk/extensions/cldr/CldrNamesYo.php (modified) (history) /trunk/extensions/cldr/CldrNamesZh_hans.php (modified) (history) /trunk/extensions/cldr/CldrNamesZh_hant.php (modified) (history) /trunk/extensions/cldr/CldrNamesZu.php (modified) (history) /trunk/extensions/cldr/CountryNames.body.php (added) (history) /trunk/extensions/cldr/CurrencyNames.body.php (added) (history) /trunk/extensions/cldr/rebuild.php (modified) (history)

Follow-up revisions

Revision	Commit summary	Author	Date
r102764	Quick fix huge number of syntax errors.	siebrand	09:00, 11 November 2011
r102808	fixing a bug with currency ingestion and weeding out drafts, also preventing ...	kaldari	19:07, 11 November 2011

Comments

#Comment by Siebrand (talk | contribs) 09:04, 11 November 2011

Introduced huge number of syntax errors quick fixed in r102764.

#Comment by Kaldari (talk | contribs) 19:08, 11 November 2011

Fixed the ingestion script in r102808.

Status & tagging log

11:32, 16 December 2011 Nikerabbit (talk | contribs) changed the status of r102705 [removed: new added: resolved]
19:09, 11 November 2011 Kaldari (talk | contribs) changed the status of r102705 [removed: fixme added: new]
09:04, 11 November 2011 Siebrand (talk | contribs) changed the status of r102705 [removed: new added: fixme]