r102687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102686‎ | r102687 | r102688 >
Date:20:50, 10 November 2011
Author:freakolowsky
Status:ok (Comments)
Tags:
Comment:
* sry about that :S ... 10x Aaron
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryBlocks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBlocks.php
——@@ -130,8 +130,8 @@
131131 $this->addWhereIf( 'ipb_user != 0', isset( $show['account'] ) );
132132 $this->addWhereIf( 'ipb_user != 0 OR ipb_range_end > ipb_range_start', isset( $show['!ip'] ) );
133133 $this->addWhereIf( 'ipb_user = 0 AND ipb_range_end = ipb_range_start', isset( $show['ip'] ) );
134 - $this->addWhereIf( 'ipb_expiry = '.$db->addQuotes($db->getInfinity(), isset( $show['!temp'] ) );
135 - $this->addWhereIf( 'ipb_expiry != '.$db->addQuotes($db->getInfinity(), isset( $show['temp'] ) );
 134+ $this->addWhereIf( 'ipb_expiry = '.$db->addQuotes($db->getInfinity()), isset( $show['!temp'] ) );
 135+ $this->addWhereIf( 'ipb_expiry != '.$db->addQuotes($db->getInfinity()), isset( $show['temp'] ) );
136136 $this->addWhereIf( "ipb_range_end = ipb_range_start", isset( $show['!range'] ) );
137137 $this->addWhereIf( "ipb_range_end > ipb_range_start", isset( $show['range'] ) );
138138 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102677* fix as per comment on CR r102625#c25856freakolowsky19:49, 10 November 2011

Comments

#Comment by Johnduhart (talk | contribs)   20:58, 10 November 2011

Can we please take the addtional 30 seconds needed to type out words fully and not say things like 'sry'?

#Comment by Freakolowsky (talk | contribs)   21:21, 10 November 2011

It's CODE review not comment review :D and if i had those 30 seconds i'd recheck the code and not make that mistake in the first place.

Status & tagging log