r102650 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102649‎ | r102650 | r102651 >
Date:13:14, 10 November 2011
Author:hashar
Status:reverted
Tags:
Comment:
correct variable name

This is caused by r102640, I have moved some code to a new function
and forgot to rename the internal variable name to match the function
parameter.
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -731,10 +731,10 @@
732732 wfProfileOut( __METHOD__ );
733733 return;
734734 }
735 -
 735+
736736 # Save to the persistent cache
737737 $this->store->startWrite( $code );
738 - foreach ( $allData as $key => $value ) {
 738+ foreach ( $data as $key => $value ) {
739739 if ( in_array( $key, self::$splitKeys ) ) {
740740 foreach ( $value as $subkey => $subvalue ) {
741741 $this->store->set( "$key:$subkey", $subvalue );

Follow-up revisions

RevisionCommit summaryAuthorDate
r102674Revert r102650, r102640. Caused breakage on translatewiki.net:...siebrand19:01, 10 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102640move store writing out of recache()...hashar11:56, 10 November 2011

Status & tagging log