r102577 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102576‎ | r102577 | r102578 >
Date:21:44, 9 November 2011
Author:jpostlethwaite
Status:ok
Tags:
Comment:
Internal error messages will be applied to retryMsg.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/GatewayForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/GatewayForm.php
@@ -574,9 +574,16 @@
575575
576576 $this->errors['general'] = ( !isset( $this->errors['general'] ) || empty( $this->errors['general'] ) ) ? array() : (array) $this->errors['general'];
577577
 578+ $this->errors['retryMsg'] = ( !isset( $this->errors['retryMsg'] ) || empty( $this->errors['retryMsg'] ) ) ? array() : (array) $this->errors['retryMsg'];
 579+
578580 foreach ( $this->adapter->getTransactionErrors() as $code => $message ) {
579581
580 - $this->errors['general'][ $code ] = $message;
 582+ if ( strpos( $code, 'internal' ) === 0 ) {
 583+ $this->errors['retryMsg'][ $code ] = $message;
 584+ }
 585+ else {
 586+ $this->errors['general'][ $code ] = $message;
 587+ }
581588 }
582589
583590 return $this->displayForm( $this->errors );

Follow-up revisions

RevisionCommit summaryAuthorDate
r102842MFT r102576, r102577, r102579, r102581, r102804, r102805, r102812, r102819, r...awjrichards02:20, 12 November 2011
r102929Re-attempting MFT r102576, r102577, r102578, r102579, r102581, r102689, r1027...khorn00:50, 14 November 2011

Status & tagging log