r102571 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102570‎ | r102571 | r102572 >
Date:20:52, 9 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Bug 31995 - Addition of PPFrame::getTitle

Applied patch by Van de Bugger

Added documentation to go with

Added code to Preprocess_HipHop too
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/includes/parser/Preprocessor.php (modified) (history)
  • /trunk/phase3/includes/parser/Preprocessor_DOM.php (modified) (history)
  • /trunk/phase3/includes/parser/Preprocessor_Hash.php (modified) (history)
  • /trunk/phase3/includes/parser/Preprocessor_HipHop.hphp (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -163,6 +163,7 @@
164164 * The Evil IP address
165165 * Tisane
166166 * Umherirrender
 167+* Van de Bugger
167168 * Ville Stadista
168169 * Vitaliy Filippov
169170 * William Demchick
Index: trunk/phase3/includes/parser/Preprocessor_DOM.php
@@ -1339,6 +1339,15 @@
13401340 function isTemplate() {
13411341 return false;
13421342 }
 1343+
 1344+ /**
 1345+ * Get a title of frame
 1346+ *
 1347+ * @return Title
 1348+ */
 1349+ function getTitle() {
 1350+ return $this->title;
 1351+ }
13431352 }
13441353
13451354 /**
Index: trunk/phase3/includes/parser/Preprocessor.php
@@ -27,7 +27,7 @@
2828 * Create a new custom frame for programmatic use of parameter replacement as used in some extensions
2929 *
3030 * @param $args array
31 - *
 31+ *
3232 * @return PPFrame
3333 */
3434 function newCustomFrame( $args );
@@ -44,7 +44,7 @@
4545 *
4646 * @param $text
4747 * @param $flags
48 - *
 48+ *
4949 * @return PPNode
5050 */
5151 function preprocessToObj( $text, $flags = 0 );
@@ -138,6 +138,13 @@
139139 * Return true if the frame is a template frame
140140 */
141141 function isTemplate();
 142+
 143+ /**
 144+ * Get a title of frame
 145+ *
 146+ * @return Title
 147+ */
 148+ function getTitle();
142149 }
143150
144151 /**
Index: trunk/phase3/includes/parser/Preprocessor_Hash.php
@@ -1268,6 +1268,15 @@
12691269 function isTemplate() {
12701270 return false;
12711271 }
 1272+
 1273+ /**
 1274+ * Get a title of frame
 1275+ *
 1276+ * @return Title
 1277+ */
 1278+ function getTitle() {
 1279+ return $this->title;
 1280+ }
12721281 }
12731282
12741283 /**
Index: trunk/phase3/includes/parser/Preprocessor_HipHop.hphp
@@ -1008,7 +1008,6 @@
10091009 */
10101010 var $depth;
10111011
1012 -
10131012 /**
10141013 * Construct a new preprocessor frame.
10151014 * @param $preprocessor Preprocessor: the parent preprocessor
@@ -1426,6 +1425,15 @@
14271426 function isTemplate() {
14281427 return false;
14291428 }
 1429+
 1430+ /**
 1431+ * Get a title of frame
 1432+ *
 1433+ * @return Title
 1434+ */
 1435+ function getTitle() {
 1436+ return $this->title;
 1437+ }
14301438 }
14311439
14321440 /**

Status & tagging log