r102552 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102551‎ | r102552 | r102553 >
Date:18:04, 9 November 2011
Author:gregchiasson
Status:deferred (Comments)
Tags:
Comment:
Re-create AFTv5 as a proper svn copy of AFTv4.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5 (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiQueryArticleFeedback.php (modified) (history)

Diff [purge]

The diff is too large to display.

Comments

#Comment by Reedy (talk | contribs)   18:06, 9 November 2011

Can we create/use a branch when we branching things? Otherwise things just clutter /trunk, and in this case, gives people an extra folder that will be checked out needlessly

#Comment by Catrope (talk | contribs)   18:07, 9 November 2011

It's not really a branch. This needs to be a separate extension with a different name so we can deploy it in parallel with the "old" AFT.

#Comment by Catrope (talk | contribs)   18:08, 9 November 2011

History preservation was done right this time, thanks. There were still modifications mixed in with the copy operation, the diff can be reviewed at r1=100806&r2=102552 http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/ArticleFeedbackv5/api/ApiQueryArticleFeedback.php?r1=100806&r2=102552

#Comment by Gregchiasson (talk | contribs)   18:09, 9 November 2011

Not sure how that got in there. Will fix.

#Comment by Gregchiasson (talk | contribs)   18:18, 9 November 2011

Actually. now that I look at it, and to avoid any further problems, should I revert and re-commit the whole thing, or is it OK to just rollback that one file and re-commit it?

#Comment by Catrope (talk | contribs)   12:55, 11 November 2011

That'll be fine.

#Comment by Tim Starling (talk | contribs)   09:44, 8 December 2011

Next time, maybe put an underscore or something between the extension name and its version?

Status & tagging log