r102537 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102536‎ | r102537 | r102538 >
Date:17:20, 9 November 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 32256) API list=search stops at first invalid result. Thanks to Lupo for finding the cause of the bug: in the code path for invalid titles, the iterator wasn't moved to the next result, so the loop kept processing the same result until it hit the limit.
Modified paths:
  • /trunk/phase3/includes/api/ApiQuerySearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuerySearch.php
——@@ -129,6 +129,7 @@
130130
131131 // Silently skip broken and missing titles
132132 if ( $result->isBrokenTitle() || $result->isMissingRevision() ) {
 133+ $result = $matches->next();
133134 continue;
134135 }
135136

Follow-up revisions

RevisionCommit summaryAuthorDate
r1025381.18wmf1: MFT r102537catrope17:22, 9 November 2011
r102547REL1_18 MFT r102537reedy17:43, 9 November 2011

Comments

#Comment by Hashar (talk | contribs)   17:47, 9 November 2011

Wonderful Lupo :)

Status & tagging log