r102485 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102484‎ | r102485 | r102486 >
Date:02:54, 9 November 2011
Author:yaron
Status:resolved (Comments)
Tags:
Comment:
Follow-up to r102365 - changed comparison to both blank and null to just use empty()
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_FormEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormEdit.php
——@@ -188,7 +188,7 @@
189189 $wgOut->setPageTitle( $s );
190190
191191 if ( $form_submitted ) {
192 - if ( !is_null( $page_name_formula ) && $page_name_formula !== '' ) {
 192+ if ( !empty( $page_name_formula ) ) {
193193 $target_name = $generated_page_name;
194194 // prepend a super-page, if one was specified
195195 if ( $wgRequest->getCheck( 'super_page' ) ) {

Sign-offs

UserFlagDate
Yaron Koreninspected05:23, 5 December 2011 (struck 05:23, 5 December 2011)
Yaron Korentested05:23, 5 December 2011 (struck 05:23, 5 December 2011)

Follow-up revisions

RevisionCommit summaryAuthorDate
r103129Follow-up to r102484 and r102485 - as aesthetically unappealing as it is, it ...yaron04:33, 15 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102365strict comparators for empty stringsjeroendedauw02:25, 8 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:34, 9 November 2011

Same problem as with previous commit.

#Comment by Yaron Koren (talk | contribs)   05:21, 5 December 2011

I believe this is fixed now - setting to "OK".

#Comment by Yaron Koren (talk | contribs)   05:24, 5 December 2011

Well, I tried setting it to "OK" (or "resolved"), but failed - but anyone else should feel free to set it to "OK".

#Comment by Yaron Koren (talk | contribs)   15:55, 5 December 2011

Changing it back to "new".

Status & tagging log