r102458 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r102457‎ | r102458 | r102459 >
Date:22:27, 8 November 2011
Author:platonides
Status:ok (Comments)
Tags:todo 
Comment:
Mark as FIXME. This three calls leak a png filename in sys_get_temp_dir() each,
tempnam() like, not the two-words filenames of RandomImageGenerator::getRandomFilenames()
They aren't produced by ApiTestCaseUpload::fakeUploadFile() either.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/api/ApiUploadTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/api/ApiUploadTest.php
——@@ -241,7 +241,7 @@
242242 $exception = false;
243243 try {
244244 list( $result, , ) = $this->doApiRequestWithToken( $params, $session,
245 - self::$users['uploader']->user );
 245+ self::$users['uploader']->user ); // FIXME: leaks a temporary file
246246 } catch ( UsageException $e ) {
247247 $exception = true;
248248 }
——@@ -324,7 +324,7 @@
325325 $exception = false;
326326 try {
327327 list( $result, $request, $session ) = $this->doApiRequestWithToken( $params, $session,
328 - self::$users['uploader']->user );
 328+ self::$users['uploader']->user ); // FIXME: leaks a temporary file
329329 } catch ( UsageException $e ) {
330330 $exception = true;
331331 }
——@@ -382,7 +382,7 @@
383383 $exception = false;
384384 try {
385385 list( $result, $request, $session ) = $this->doApiRequestWithToken( $params, $session,
386 - self::$users['uploader']->user );
 386+ self::$users['uploader']->user ); // FIXME: leaks a temporary file
387387 } catch ( UsageException $e ) {
388388 $exception = true;
389389 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r105550clean some files when testing upload...hashar14:03, 8 December 2011

Comments

#Comment by Hashar (talk | contribs)   11:51, 5 December 2011

To me the issue appears to be in the API on action=upload

#Comment by Platonides (talk | contribs)   22:52, 7 December 2011

Did you find the source? I hadn't followed it deeper.

#Comment by Hashar (talk | contribs)   14:03, 8 December 2011

r105550 catch files matching ??????

Cant find out from where the ??????.png files are created from though :(

Status & tagging log