r102426 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102425‎ | r102426 | r102427 >
Date:19:28, 8 November 2011
Author:gregchiasson
Status:reverted (Comments)
Tags:
Comment:
Committing a non-working untested copy of the first go at this extension, mostly so we have a checkpoint to look at/review, and also to make sure commit access works.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5 (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedback.alias.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedback.hooks.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedback.i18n.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedback.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedback.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/api (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedback.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiArticleFeedbackUtils.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/api/ApiQueryArticleFeedback.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedback (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedback/ext.articleFeedback.css (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedback/ext.articleFeedback.dashboard.css (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedback/ext.articleFeedback.dashboard.js (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedback/ext.articleFeedback.js (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedback/ext.articleFeedback.startup.js (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images.psd (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/alert.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/attention.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/chart-base.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/chart-fill.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/form-hover.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/form.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/question-hover.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/question.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/report-hover.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/report.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/segment-empty.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/segment-full.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/star-empty.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/star-full-expired.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/star-full.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/star-new-down.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/star-new-hover.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/star-new.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/success.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/trash-hover.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/images/trash.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/jquery.articleFeedback.css (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedback/jquery.articleFeedback.js (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/populateAFRevisions.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/populateAFStatistics.php (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/AddArticleFeedbackPageIndex.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/AddArticleFeedbackStatsTable.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/AddArticleFeedbackStatsTypeTable.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/AddArticleFeedbackTimestampIndex.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/AddPropertiesTable.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/AddPropertiesValueText.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/AddRatingBucket.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/AddRevisionsTable.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/ArticleFeedback.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/FixAnonTokenSchema.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/FixPropertiesAnonTokenSchema.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/MigrateArticleFeedbackStatsHighsLows.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/RecreatePK.sql (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/sql/RenameTables.sql (added) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r102551Per Roan, this was created wrong in r102426. Will re-add, properly using svn ...gregchiasson18:02, 9 November 2011

Comments

#Comment by Eloquence (talk | contribs)   21:50, 8 November 2011

One thing we'll have to make sure is that AFTv5 and AFT can be deployed in parallel (because we'll be continuing use of the old system while we're trying the new one). This will likely mean changing message key prefixes, table prefixes, and other unique identifiers to avoid conflicts. We should aim to have both versions running on the prototype server ASAP.

#Comment by Catrope (talk | contribs)   16:59, 9 November 2011

So did you copy the extension on your local system, modify it, then commit it? That's the worst thing you could've done with regards to preserving history. You should use svn copy to make sure the history is preserved, and you shouldn't copy and modify in the same revision.

I outlined this in an e-mail I sent to Fabrice and Yoni on October 25th:

Also, please use svn copy to fork the extension, and svn rename to rename the files in your copy; that way history is preserved. Also, do not copy/rename and change a file in the same commit, doing so makes review harder. All this means you'll probably need 3 commits to fork the extension: one for a verbatim copy, one to rename all the files, and one to update the contents of the files to match the changed extension name, file names, prefixes, etc.

Please revert this revision and execute the clone properly. If you have trouble doing these things, I'm willing to do it for you.

Status & tagging log