r102404 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102403‎ | r102404 | r102405 >
Date:15:51, 8 November 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
clearMessageBlogs didn't take localisationupdate into account
Also saw no point doing file_exists for files returned by glob
Modified paths:
  • /trunk/extensions/WikimediaMaintenance/clearMessageBlobs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaMaintenance/clearMessageBlobs.php
@@ -24,12 +24,14 @@
2525 }
2626
2727 foreach ( glob( "$IP/languages/messages/Messages*.php" ) as $file ) {
28 - if ( !file_exists( $file ) ) {
29 - continue;
30 - }
3128 $maxTime = max( $maxTime, filemtime( $file ) );
3229 }
3330
 31+ # LocalisationUpdate
 32+ foreach ( glob( "$IP/cache/l10n/*.cache" ) as $file ) {
 33+ $maxTime = max( $maxTime, filemtime( $file ) );
 34+ }
 35+
3436 if ( !file_exists( "$IP/cache/message-timestamp" ) ) {
3537 $this->clearBlobs();
3638 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r1024051.18wmf1: MFT r102404catrope16:01, 8 November 2011

Status & tagging log