r102361 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102360‎ | r102361 | r102362 >
Date:01:26, 8 November 2011
Author:siebrand
Status:reverted (Comments)
Tags:
Comment:
Fix bug. A group can be both be a parent and have a parent.
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialLanguageStats.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/specials/SpecialLanguageStats.php
@@ -329,7 +329,9 @@
330330 $rowParams['data-groupid'] = $group->getId();
331331 if ( is_string( $parent ) ) {
332332 $rowParams['data-parentgroups'] = $parent;
333 - } elseif ( $parent === true ) {
 333+ }
 334+
 335+ if ( $parent === true ) {
334336 $rowParams['data-ismeta'] = '1';
335337 }
336338

Follow-up revisions

RevisionCommit summaryAuthorDate
r102765Revert r102361. Didn't work.siebrand09:05, 11 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   10:24, 8 November 2011

Behavior before and after this fix?

#Comment by Siebrand (talk | contribs)   12:02, 8 November 2011

Unchanged, as far as I can tell. Should probably be reverted. Tried to fix the overcounting for meta groups that contain meta groups, but this didn't fix it...

Status & tagging log